[dkms] Match the module name to what is in Kbuild#18
[dkms] Match the module name to what is in Kbuild#18tsirakisn wants to merge 1 commit intoOpenXT:masterfrom
Conversation
|
I think it would be better to leave the module name as xen-argo.ko and just change dkms.conf. Would that work for you? This module is xen-specific, so including xen in the name helps identify that. argo.ko on its own doesn't tell you anything unless you already know what it is. Also wouldn't renaming this module require changes to xenclient-oe since that uses the name xen-argo already? |
FWIW I agree with this. I was following the convention that someone had introduced in an earlier commit (d24274e). I guess OpenXT never uses dkms to build the argo driver, so it must have just been a dormant bug since that change. I'll reverse this as requested and keep xen-argo as the module name. |
Kbuild generates the .ko name from the contents of the Kbuild file, but these lines do not match the module name defined in dkms.conf. This commit aligns the two. Signed-off-by: Nicholas Tsirakis <tsirakisn@ainfosec.com>
894655f to
4e60cd1
Compare
Kbuild generates the .ko name from the contents of the Kbuild file, but these lines do not match the module name defined in dkms.conf. This commit aligns the two.
Signed-off-by: Nicholas Tsirakis tsirakisn@ainfosec.com