Add settings for PDC plugin in construct function, like in OpenPub plugin #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yard,
In een thema waarin we de PDC plugin gebruiken, willen we de PDC plugin classes zoals de ItemController gebruiken. Om die reden laden we de Plugin class in. Echter krijgen we een fatal error:
PHP Fatal error: Uncaught Error: Call to a member function useShowOn() on null in C:\Users\eyal_\Local Sites\sittard-geleennl\app\public_html\wp-content\plugins\pdc-base\src\Base\RestAPI\Controllers\ItemController.php:164Met de toevoeging in deze PR is dit probleem opgelost. Dit stukje code in de __construct van de plugin staat wél in de OpenPub plugin, maar niet hier in de PDC plugin.