Skip to content

Memoize debounced submit and add cleanup #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakinoharaShoko merged 2 commits into from
May 28, 2026
Merged

Memoize debounced submit and add cleanup #603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f854c7
Memoize debounced submit and add cleanup
MakinoharaShoko May 13, 2026
272f3a4
Merge branch 'dev' into fix-text-editor
MakinoharaShoko May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/origine2/src/pages/editor/TextEditor/TextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ export default function TextEditor(props: ITextEditorProps) {
* @param {string} value
* @param {any} ev
*/
const handleChange = useMemo(() => debounce((value: string | undefined, ev: monaco.editor.IModelContentChangedEvent) => {
if (!isEditorReady.value) return;
const submitChange = useMemo(() => debounce((value: string | undefined, ev: monaco.editor.IModelContentChangedEvent) => {
logger.debug('编辑器提交更新');
// 这里直接使用临时储存的行数, 一般来说光标位置就在改变的行
const lineNumber = editorLineHolder.getSceneLine(props.targetPath);
Expand All @@ -129,7 +128,16 @@ export default function TextEditor(props: ITextEditorProps) {
lineCommandString: targetValue,
});
});
}, 500), []);
}, 500), [props.targetPath, target?.path]);

const handleChange = (value: string | undefined, ev: monaco.editor.IModelContentChangedEvent) => {
if (!isEditorReady.value) return;
submitChange(value, ev);
};
Comment on lines +133 to +136

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The handleChange function is currently recreated on every render. Since it is passed as a prop to the Editor component, it should be memoized using useCallback. This ensures that the Editor component doesn't receive a new function reference unless its dependencies change, which can prevent unnecessary internal updates or side effects within the editor wrapper.

Suggested change
const handleChange = (value: string | undefined, ev: monaco.editor.IModelContentChangedEvent) => {
if (!isEditorReady.value) return;
submitChange(value, ev);
};
const handleChange = useCallback((value: string | undefined, ev: monaco.editor.IModelContentChangedEvent) => {
if (!isEditorReady.value) return;
submitChange(value, ev);
}, [submitChange, isEditorReady]);


useEffect(() => {
return () => submitChange.flush();
}, [submitChange]);

const syncCurrentLine = useCallback(() => {
const lineNumber = editorLineHolder.getSceneLine(props.targetPath) || editorRef.current?.getPosition()?.lineNumber || 1;
Expand All @@ -148,8 +156,6 @@ export default function TextEditor(props: ITextEditorProps) {
};
}, [syncCurrentLine]);

useEffect(() => () => handleChange.flush(), [handleChange]);

function updateEditData() {
const path = props.targetPath;
axios
Expand Down
Loading