fix: add Intent flag on open browser#599
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a BrowserUtils utility to centralize browser intent creation and error handling, which is integrated into MainScreen.kt. It also updates intent flags in Notification.kt. Review feedback recommends removing an unused import in BrowserUtils.kt, refactoring the intent creation into a reusable method to eliminate logic duplication between BrowserUtils and Notification.kt, and improving variable naming for better code clarity.
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.widget.Toast | ||
| import androidx.browser.customtabs.CustomTabsIntent |
There was a problem hiding this comment.
导入了未使用的 CustomTabsIntent，建议将其移除以保持代码整洁。
| fun openBrowser(context: Context, url: String) { | ||
| val uri = url.toUri() | ||
| val intent = Intent(Intent.ACTION_VIEW, uri).apply { | ||
| addCategory(Intent.CATEGORY_BROWSABLE) | ||
| setFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
| } | ||
| try { | ||
| context.startActivity(intent) | ||
| } catch (e2: ActivityNotFoundException) { | ||
| Toast.makeText( | ||
| context, | ||
| context.getString(R.string.could_not_open_browser), | ||
| Toast.LENGTH_SHORT | ||
| ).show() | ||
| } | ||
| } |
There was a problem hiding this comment.
建议将 Intent 的创建逻辑提取到一个独立的方法中，这样可以在 Notification.kt 等其他地方复用，避免逻辑重复。同时，建议将异常变量名 e2 修改为更符合规范的 e。
fun createBrowserIntent(url: String): Intent =
Intent(Intent.ACTION_VIEW, url.toUri()).apply {
addCategory(Intent.CATEGORY_BROWSABLE)
setFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
}
fun openBrowser(context: Context, url: String) {
try {
context.startActivity(createBrowserIntent(url))
} catch (e: ActivityNotFoundException) {
Toast.makeText(
context,
context.getString(R.string.could_not_open_browser),
Toast.LENGTH_SHORT
).show()
}
}| Intent(Intent.ACTION_VIEW, context.getString(R.string.local_url).toUri()).apply { | ||
| addCategory(Intent.CATEGORY_BROWSABLE) | ||
| setFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
| } |
There was a problem hiding this comment.
此处的 Intent 创建逻辑与 BrowserUtils 中的重复。建议复用 BrowserUtils.createBrowserIntent 以保持逻辑统一。注意：由于包路径不同，建议使用全限定名或在文件顶部添加相应的 import。
com.openwebgal.terre.utils.BrowserUtils.createBrowserIntent(context.getString(R.string.local_url))
2 participants
解决某些安卓设备无法打开浏览器的问题