Open
Conversation
- Replace deprecated np.float with np.float64 in my_awing_arch.py and torch2onnx.py (np.float was removed in NumPy 1.24) - Fix ValueError in align_img by explicitly casting t[0] and t[1] to float when building trans_params array Fixes OpenTalker#1019 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
hi, any chance this could get reviewed? fixes numpy 1.24+ deprecations (np.float, np.int, etc.) that crash on newer setups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compatibility issues when running SadTalker with NumPy >= 1.24.
Problems Fixed
1.
np.floatdeprecationnp.floatwas deprecated in NumPy 1.20 and removed in NumPy 1.24.Fix: Replaced
np.floatwithnp.float64in:src/face3d/util/my_awing_arch.pysrc/face3d/models/arcface_torch/torch2onnx.py2. ValueError in
align_imgThis happened because
t[0]andt[1]were arrays instead of scalars.Fix: Explicitly cast values to float in
src/face3d/util/preprocess.py:Fixes #1019
🤖 Generated with Claude Code