fix: address high priority code review issues

- Fix secrets parsing to properly extract required field from inline metadata
- Add context to installWorkflow error messages
- Add test for required: false secrets parsing
- Update test fixture with mixed required values
- Remove testing branch from CI triggers

Author: MichaelFisher1997

.github/workflows/test.yml

@@ -2,9 +2,9 @@ name: Tests
 
 on:
   push:
-    branches: [main, master, testing]
+    branches: [main, master]
   pull_request:
-    branches: [main, master, testing]
+    branches: [main, master]
 
 jobs:
   test:

src/core/registry.test.ts

@@ -95,14 +95,20 @@ describe('WorkflowRegistry', () => {
       expect(workflow?.type).toBe('set');
     });
 
-    test('should parse multiple secrets', async () => {
+    test('should parse multiple secrets with required field', async () => {
       await registry.load();
       const workflow = registry.getWorkflow('test-category/another-workflow');
 
       expect(workflow?.metadata.secrets.length).toBe(2);
       const secretNames = workflow?.metadata.secrets.map(s => s.name);
       expect(secretNames).toContain('API_KEY');
       expect(secretNames).toContain('TOKEN');
+      
+      // Verify required field is parsed correctly
+      const apiKeySecret = workflow?.metadata.secrets.find(s => s.name === 'API_KEY');
+      const tokenSecret = workflow?.metadata.secrets.find(s => s.name === 'TOKEN');
+      expect(apiKeySecret?.required).toBe(true);
+      expect(tokenSecret?.required).toBe(false);
     });
   });
 

src/core/registry.ts

@@ -273,12 +273,15 @@ export class WorkflowRegistry {
     const secrets: SecretRequirement[] = [];
     const secretsBlock = content.match(/# secrets:[\s\S]*?(?=\n# [a-z]|\n\n|$)/i);
     if (secretsBlock) {
-      const regex = /#\s+- name:\s*(\S+)[\s\S]*?#\s+description:\s*(.+)/g;
-      for (const item of secretsBlock[0].matchAll(regex)) {
+      // Match individual secret entries with name, description, and optional required field
+      const entryRegex = /#\s+- name:\s*(\S+)[\s\S]*?#\s+description:\s*([^\n]+)(?:[\s\S]*?#\s+required:\s*(true|false))?/g;
+      for (const item of secretsBlock[0].matchAll(entryRegex)) {
         const name = item[1];
         const description = item[2];
+        const requiredStr = item[3];
         if (!name || !description) continue;
-        secrets.push({ name, description: description.trim(), required: true });
+        const required = requiredStr ? requiredStr.trim() === 'true' : true;
+        secrets.push({ name, description: description.trim(), required });
       }
     }
 

src/test/fixtures/test-category/another-workflow/another-workflow.yml

@@ -8,8 +8,10 @@
 # secrets:
 #   - name: API_KEY
 #     description: API key for service
+#     required: true
 #   - name: TOKEN
 #     description: Authentication token
+#     required: false
 # triggers:
 #   - schedule
 # variants:

src/tui/utils/install-workflow.ts

@@ -82,9 +82,10 @@ export async function installWorkflow(
       },
     };
   } catch (error) {
+    const message = error instanceof Error ? error.message : 'Unknown error occurred';
     return {
       success: false,
-      message: error instanceof Error ? error.message : 'Unknown error occurred',
+      message: `Failed to install workflow: ${message}`,
     };
   }
 }