fix: address code review feedback

- Improve error handling in discoverCategories to distinguish ENOENT from other errors
- Add required field to test fixture secrets and update test assertion
- Log warnings for unexpected filesystem errors

Author: MichaelFisher1997

src/core/registry.test.ts

@@ -73,7 +73,7 @@ describe('WorkflowRegistry', () => {
       expect(workflow?.metadata.secrets.length).toBe(1);
       expect(workflow?.metadata.secrets[0]?.name).toBe('TEST_SECRET');
       expect(workflow?.metadata.secrets[0]?.description).toBe('A test secret');
-      expect(workflow?.metadata.secrets[0]?.required).toBeUndefined();
+      expect(workflow?.metadata.secrets[0]?.required).toBe(true);
     });
 
     test('should parse triggers from metadata', async () => {

src/core/registry.ts

@@ -85,8 +85,13 @@ export class WorkflowRegistry {
           path: join(this.workflowsRoot, entry.name),
         });
       }
-    } catch {
-      // Directory doesn't exist or can't be read, return empty categories
+    } catch (error) {
+      // Only ENOENT (directory doesn't exist) is expected - other errors should be logged
+      if (error instanceof Error && 'code' in error && error.code === 'ENOENT') {
+        // Expected - directory doesn't exist, return empty categories
+      } else {
+        console.warn('Warning: Could not read workflows directory:', error);
+      }
     }
     return categories;
   }

src/test/fixtures/test-category/simple-workflow/simple-workflow.yml

@@ -8,6 +8,7 @@
 # secrets:
 #   - name: TEST_SECRET
 #     description: A test secret
+#     required: true
 # triggers:
 #   - push
 #   - pull_request