fix: resolve actionlint shellcheck failures in workflow files#401
Merged
MichaelFisher1997 merged 1 commit intodevfrom Apr 1, 2026
Merged
fix: resolve actionlint shellcheck failures in workflow files#401MichaelFisher1997 merged 1 commit intodevfrom
MichaelFisher1997 merged 1 commit intodevfrom
Conversation
Quote GITHUB_ENV/GITHUB_OUTPUT variables and group redirect statements to satisfy SC2086, SC2129, and remove unused TOTAL variable (SC2034).
github-actions
bot
added
documentation
Contributor
📋 SummaryThis PR addresses shellcheck issues in GitHub workflow files identified by actionlint (run #23869757250). The changes implement standard bash best practices:
No linked issues mentioned in the PR description. The changes are straightforward CI maintenance fixes that improve shell script reliability and follow best practices. 🔴 Critical Issues (Must Fix - Blocks Merge)None identified.
|
| Principle | Score | Notes |
|---|---|---|
| Single Responsibility | 10 | Each workflow has a clear, focused purpose |
| Open/Closed | N/A | Workflow files don't apply to OCP |
| Liskov Substitution | N/A | No inheritance hierarchy |
| Interface Segregation | N/A | Workflows are concrete implementations |
| Dependency Inversion | N/A | CI workflows call external actions |
| Average | 10.0 | Simple, focused changes |
🎯 Final Assessment
Overall Confidence Score: 95%
Confidence Breakdown:
- Code Quality: 95% (follows shellcheck best practices)
- Completeness: 100% (addresses all reported issues)
- Risk Level: 5% (minimal risk - shell quoting fixes)
- Test Coverage: 90% (CI will validate on next run)
Merge Readiness:
- All critical issues resolved
- SOLID average score >= 6.0
- Overall confidence >= 60%
- No security concerns
- Tests present and passing (CI will validate)
Verdict:
MERGE
This is a clean, focused PR that properly addresses all shellcheck issues. The changes follow bash best practices and will improve CI reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all shellcheck issues reported by the actionlint CI job (run #23869757250).
Changes
echo >> $GITHUB_ENVredirects into{ ... } >> "$GITHUB_ENV"invisual-test.ymlandbuild.yml$GITHUB_ENVand$GITHUB_OUTPUTacross 5 workflow files to prevent globbing/word splittingTOTALvariable inopencode-test-writer.ymlFiles Changed
.github/workflows/visual-test.yml— SC2129 + SC2086 (3 locations).github/workflows/build.yml— SC2086 (Wayland compositor step).github/workflows/opencode-test-writer.yml— SC2034 (unused TOTAL).github/workflows/opencode-pr.yml— SC2086 (cache prep).github/workflows/opencode.yml— SC2086 (cache prep)