Test location fix for non GPS tablets #2465
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello good night,
I'm testing out a fix to retrieve the location from my Lenovo Tab P11 Gen 2. The tablet doesn't have an internal GPS and it uses the Fused Location Provider instead of the GPS provider required by Open Orienteering Mapper.
The thing is, I have a Garmin Glo 2 external GPS that I'm running with the Bluetooth GNSS app mocking the location and still I'm not able to run the app because that doesn't change the tablet doesn't have a GPS provider available.
I opened the PR so that the pipeline builds the APK for me as I'm currently sitting at a Windows computer and I felt like this was going to be the fastest way of testing it by reading this documentation.
Regardless of the answer, big thanks for you work on this project and for spending the time reading my answer. I hope you can find this idea cool and provide support to even more people that want to get started with OOM like me 😃
EDIT:
Long story short, it works. Now OOM doesn't say I do not have GPS and the location is perfect because I'm running the Garmin Glo 2.
Now my question is... Would it be possible to include this on the next release @dg0yt?
Of course, not in the current state. I have no idea about C++ development but I could try to make this configurable through a checkbox on the location settings saying something like
so that the users only checks them knowing what is it exactly for. Still I don't know if only the current changes and this checkbox I'm mentioning are the only needed changes... 😞
I truly believe this is a cool feature that will enable a lot of users to use OOM. Let me know what you think!