Introduce Exponential mechanism to Budget Accounting#539
Open
dvadym wants to merge 3 commits intoOpenMined:mainfrom
Open
Introduce Exponential mechanism to Budget Accounting#539dvadym wants to merge 3 commits intoOpenMined:mainfrom
dvadym wants to merge 3 commits intoOpenMined:mainfrom
Conversation
RamSaw
approved these changes
Mar 31, 2025
Collaborator
RamSaw
left a comment
There was a problem hiding this comment.
How does it work? Shouldn't change any mechanism specific code?
| self.assertEqual(budget1.eps, 0.4) | ||
| self.assertEqual(budget1.delta, | ||
| 0) # Delta should be 0 if mechanism is Laplace. | ||
| self.assertEqual(budget1.eps, 0.2) |
Collaborator
There was a problem hiding this comment.
maybe write a formula, not trivial
| weight=8, | ||
| sensitivity=3), | ||
| ], | ||
| expected_pipeline_noise_std=40.02) |
Collaborator
There was a problem hiding this comment.
should we write/point to the formulas in the class definition?
Collaborator
Author
There was a problem hiding this comment.
Yeah, we should write documentation on PLD accountant. In this case, there is no simple formula anyway :)
dvadym
commented
Apr 2, 2025
Collaborator
Author
dvadym
left a comment
There was a problem hiding this comment.
Thanks for review!
| weight=8, | ||
| sensitivity=3), | ||
| ], | ||
| expected_pipeline_noise_std=40.02) |
Collaborator
Author
There was a problem hiding this comment.
Yeah, we should write documentation on PLD accountant. In this case, there is no simple formula anyway :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atm dp_accounting doesn't support yet Exponential mechanism natively, so for PLD accounting PLD from eps-DP mechanism (which is actually eps-randomzed response) is used. eps-Randomized response is dominating any eps-DP so it's safe from privacy perspective, but it results in slightly higher noise.