Open
Conversation
Author
|
This is the initial commit for Issue Support Dockerfile for Env Dependencies Issue #245. @chinmayshah99 |
dvadym
reviewed
Mar 15, 2022
Collaborator
dvadym
left a comment
There was a problem hiding this comment.
Sorry for late reply, the last 3 weeks with the situation in Ukraine were crazy.
chinmayshah99
requested changes
Apr 25, 2022
Author
|
Nope, I will update the pull request then
… On Apr 25, 2022, at 11:22 AM, Chinmay Shah ***@***.***> wrote:
@chinmayshah99 requested changes on this pull request.
In Dockerfile/restaraunt_visits_without_frameworks/Dockerfile <#246 (comment)>:
> +# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+# base image
+FROM ubuntu:20.04
+
+# maintainer
+MAINTAINER wenhui ***@***.***> ***@***.***> ***@***.***>
+
+# commands executed in terminal
+RUN set -x
+
+# build deps
+RUN apt-get update
+RUN apt-get -y install git vim
Is vim required?
In README.md <#246 (comment)>:
> @@ -116,6 +116,45 @@ sample of it. Here's how to take a subset of the data in bash:
3. Run `python movie_view_ratings.py --input_file=<path to data.txt from 2> --output_file=<...>`
+## Dockerfile to tryout
+To build and test a Dockerfile, please:
+```
+cd ./Dockerfile
+
+docker image build -t $test_case:$version
this seems to be a typo. In the current version of the dockerfile, there is no support for different files
—
Reply to this email directly, view it on GitHub <#246 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARUYPPUYANOCXME4XB6EUTVG3PGNANCNFSM5OIAUVYA>.
You are receiving this because you authored the thread.
|
|
|
||
| # download source | ||
| RUN git clone https://github.com/OpenMined/PipelineDP.git | ||
| RUN cd /PipelineDP && git checkout v0.1.1 |
Member
There was a problem hiding this comment.
need to change this version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dockerfile for one of the test
Affected Dependencies
readme file
Dockerfile folder
How has this been tested?
as stated in the readme file
Checklist