feat: add AirQualityInput plugin with multi-connector pattern (AQICN, PMS5003, BME680)#2437
Open
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Open
feat: add AirQualityInput plugin with multi-connector pattern (AQICN, PMS5003, BME680)#2437Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Conversation
- Add AirQualityInput plugin supporting multiple sensors/APIs - Add connector/base.py: AirQualityData dataclass, AirQualityConnector ABC, get_aqi_level() - Add connector/aqicn.py: AQICN cloud API connector (no hardware needed) - Add connector/pms5003.py: PMS5003/PMS7003 particulate sensor via Serial - Add connector/bme680.py: BME680 environmental sensor via I2C - Add 88 tests covering all connectors and plugin behavior (100% coverage) - Patch inputs/__init__.py auto-discovery to support subpackage plugins - Fix aqi_label/aqi_description unbound variable in _raw_to_text
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Fix test_base.py: add type: ignore[abstract] for abstract instantiation - Fix test_bme680.py: assert aqi is not None before comparison - Add tests for subpackage scanning in inputs/__init__.py (100% coverage) - Add tests for load_input error paths (ImportError, AttributeError) - Move inline 'import types' to top-level in test_init.py - Use setattr() for ModuleType attribute assignment (pyright)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a generic
AirQualityInputplugin that supports multiple air quality sensors and APIs via a connector pattern. This allows OM1 to read real-time air quality data without changing the core plugin when switching sensors. #365Features
AirQualityDataand converts it to human-readable text for the LLMaqicn— AQICN World Air Quality Index cloud API (no hardware needed)pms5003— PMS5003/PMS7003 particulate matter sensor via Serial/UARTbme680— BME680 environmental sensor (temperature, humidity, VOC) via I2CSensors Integrated
aqicnpms5003bme680Configuration Example