fix: correct backward movement comparison in TurtleBot4 MoveZenohConnector#2431
Open
dolepee wants to merge 9 commits intoOpenMind:mainfrom
Open
fix: correct backward movement comparison in TurtleBot4 MoveZenohConnector#2431dolepee wants to merge 9 commits intoOpenMind:mainfrom
dolepee wants to merge 9 commits intoOpenMind:mainfrom
Conversation
added 9 commits
February 10, 2026 06:13
github-actions
bot
added
robotics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the backward movement comparison logic in the TurtleBot4 MoveZenohConnector to correctly handle negative goal_dx values by using absolute values where appropriate.\n\n## Changes\n- Use when calculating remaining distance\n- Use in comparisons for keep advancing / overshoot\n\n## Testing\nManual testing on TurtleBot4 platform recommended to verify backward movements are correctly timed and measured.