fix: correct Queue truthiness check in TwitterInput plugin#2430
Open
dolepee wants to merge 1 commit intoOpenMind:mainfrom
Open
fix: correct Queue truthiness check in TwitterInput plugin#2430dolepee wants to merge 1 commit intoOpenMind:mainfrom
dolepee wants to merge 1 commit intoOpenMind:mainfrom
Conversation
Changed to in src/inputs/plugins/twitter.py (line 121). Queue objects are always truthy, leading to get_nowait() calls on empty queue. Fixes issue OpenMind#2411.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2411. The TwitterInput plugin used which always evaluates True for a Queue object, causing get_nowait() to be called even when the queue is empty. This relied on catching Empty exceptions rather than proper flow control.\n\nChanged to to correctly check for messages before attempting to retrieve them.\n\nThis is a tiny but important bug fix that eliminates unnecessary exception handling and improves efficiency.