Open
Conversation
github-actions
bot
added
the
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation for the Screen Animation Service configuration in the BrainPack full autonomy guidelines. The changes improve the reliability of the fullscreen kiosk mode by using wmctrl to force fullscreen behavior after Chromium launches, addressing potential issues with the --kiosk flag alone.
Changes:
- Added
wmctrlas a required dependency alongsideunclutter - Modified the startup script to run Chromium in the background and use
wmctrlto enforce fullscreen mode - Added process lifecycle management with PID tracking and
waitto properly maintain the systemd service
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the docs for setting screen animation