fix: add thread safety to navigation and localization providers#2422
Open
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Open
fix: add thread safety to navigation and localization providers#2422Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Conversation
- Add threading.Lock to UnitreeGo2NavigationProvider, UnitreeG1NavigationProvider, and UnitreeGo2LidarLocalizationProvider - Protect all shared state access (_nav_in_progress, _current_destination, navigation_status, localization_status, localization_pose) with lock - Add lock to all properties (navigation_state, is_navigating, is_localized, pose) - Update tests to 100% coverage for all three providers
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add threading.Lock to three Unitree providers to prevent race conditions
between Zenoh callback threads and the main thread accessing shared state.
Changes
src/providers/unitree_go2_navigation_provider.py
threading.Lockto protect_nav_in_progress,_current_destination, andnavigation_statusnavigation_stateandis_navigatingsrc/providers/unitree_g1_navigation_provider.py
threading.Lockto protect_nav_in_progress,_current_destination, andnavigation_statusnavigation_stateandis_navigatingnavigation_status_message_callbacksrc/providers/unitree_go2_lidar_localization_provider.py
threading.Lockto protectlocalization_statusandlocalization_poseis_localizedandposeself._lockinitialization