fix: rename adding_pending_message to add_pending_message in UbTtsProvider#2416
Open
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Open
fix: rename adding_pending_message to add_pending_message in UbTtsProvider#24160xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Conversation
…vider All other TTS providers (elevenlabs, kokoro, riva, ros2_publisher, zenoh_publisher) use add_pending_message. The hook system and greeting conversation connector call add_pending_message on any TTS provider, causing AttributeError when UbTtsProvider is used through the generic TTS interface.
github-actions
bot
added
robotics
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other TTS providers (elevenlabs, kokoro, riva, ros2_publisher, zenoh_publisher) implement
add_pending_message.UbTtsProviderusesadding_pending_messageinstead, breaking the generic TTS interface.The hook system (
runtime/hook.py:266), greeting conversation connector, and navigation providers all callprovider.add_pending_message(...)— any of these will crash withAttributeErrorwhenUbTtsProvideris the configured TTS provider.The only caller that worked was
speak/connector/ub_tts.pybecause it directly used the wrong name. Updated both the provider and all callers/tests.