fix: use .message field instead of Message repr in MockInput output#2415
Open
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Open
fix: use .message field instead of Message repr in MockInput output#24150xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Conversation
formatted_latest_buffer was embedding the full Message dataclass repr (Message(timestamp=..., message='...')) in the f-string instead of just the .message text field. This sent garbage to the LLM prompt.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatted_latest_bufferwas embedding the fullMessagedataclass repr in the f-string ({self.messages[-1]}) instead of the.messagetext field ({self.messages[-1].message}). This caused the LLM to receiveMessage(timestamp=1708700000.0, message='Hello...')instead of justHello....Line 263 already uses
.messagecorrectly foradd_input()— the f-string on line 259 was the only place that missed it.