refactor(twitter): simplify TwitterInput following NewsInput pattern#2413
Open
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Open
refactor(twitter): simplify TwitterInput following NewsInput pattern#2413Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Conversation
- Remove Queue, message_buffer, start(), listen() override, _query_context(), initialize_with_query() dead code - Add poll_interval to TwitterSensorConfig for API rate limiting - _poll() fetches API directly with interval guard - Add io_provider.add_input() in formatted_latest_buffer()
github-actions
bot
added
robotics
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
TwitterInputto follow the same pattern asNewsInput,fixing the root cause behind #2411 and several other issues found
during analysis.
Problems Found
if self.message_buffer:always evaluates toTrue(reported in self.message_buffer is a Queue object. In Python, a Queue instance is always truthy regardless of whether it's empty, so the check if self.message_buffer: never evaluates to False. #2411)listen()was overriding base class unnecessarilystart(), never refreshed during runtime_poll()→raw_to_text()→ back to Queuestart(),initialize_with_query(),_query_context()were dead codeio_provider.add_input()was missing, inconsistent with other pluginsself.bufferandself.contextwere redundant and confusingChanges
Queue,message_buffer,start(),listen()override,_query_context(),initialize_with_query()poll_intervaltoTwitterSensorConfig(default: 60s)_poll()fetches API directly with interval guardformatted_latest_buffer()now callsio_provider.add_input()