Rewrote base level self condition check#3890
Open
hexhexD wants to merge 2795 commits into
Open
Conversation
* [Tables] pRO Update 2020-12-10 * [Network] pRO Update 2020-12-10
* Add 0AB9 / 0B13 * Fix bug T.T * I'm forget sakexe
Small fix: - added description to commands (exp) - fixed the command "reload priority" - not all changes were applied - changed hooks "incoming_deal" and "party_invite" - added a new package: '0A96' (deal_add_other) - changed the package '0801' (buy_bulk_vender)
now the command is working again
"Can't locate loadable object for module XSTools"
* fixed cash shop:
- added description to 'cash' and 'cashbuy' commands
- now the 'cash list' command does not require running the 'cash open' command. After all, we receive this information immediately after loading the map
- fixed the 'cash buy <item_name>' command
- added clearing of the variable '$cashShop{points}' after the store was closed, otherwise the 'cash open' command did not work after the store was closed
- updated the 'cash_shop_list' function. Added support for items 4 bytes ($self->{cash_shop_list_pack})
- updated the 'cash_shop_buy_result' function
* fix checks:
Python2 is absent on Ubuntu 20. We need to install it manually
* fixed attendance_ui function - now it shows the correct number of days - added a new config parameter: "attendanceAuto" https://openkore.com/wiki/AttendanceAuto https://openkore.com/wiki/Attendance
* removed scons 3.0.1 * added scons 3.1.2 * updated makefile and build scripts to support python 2.7 and 3.5+ versions * updated tests * updated github actions (new build check) * code cleanup Co-authored-by: ya4ept <ya4ept@ya.ru>
- nameID changed from 2 bytes to 4 bytes - did sort alphabetically
* GGamerzRO private server removed Server is officially closed on 15/2/2021 due to no more Sponsor.
* Exchanged field files * changed config settings * Pathfinding changes * Source code changes * plugin changes * exchanged dlls * Fix typo in Pathfinding.xs * Changes to Task::Route Logic * added constants and added start to solution * Added field as a requirement for Task::Route * Added check for walkable cell in portalos calculation. Fixed misc sub * Fix in Route arguments * Fix a few typos * Cleared AttackCanSnipe code * Moved 3 subs to Field.pm * Add many comments, removed unused variable. * Added failsafe and actor avoiding * Reorganized pathfinding subs * syntax changes, comments and code cleaning * Added a few defined checks * beta changes in checklos * Reworked attackCanSnipe and AttackCheckLOS * changed noAvoidWalls to avoidWalls * removed avoidwalls from attackcansnipe * Cleaned cansnipe a bit * Changes to attack logic Adapted meeting position to be able to be used by other actors. Changed many distance checks in AI::Slave to blockdistance. Added a check in Task::Route for DistFromGoal cleaning the solution. Changed a few field subs. * change config key * Added a few more checks * Fix conflict * Adapted slave changes * added $pos declaration * fixed checkLineWalkable call * Fixed calcRectArea in tests * added attackChangeTargetDuringLOSRoute * Fixed a lot bug bugs with approaching monsters * Removed import * changed attackMaxDistance * updated dlls * Made route.pm a bit more responsive * fixed wrong checking order in Route.pm * A few more changes to route.pm, ported Attack.pm change to Slave.pm * Fixed reference copy in route.pm * Fixed another reference copy * fixed timeout * small changes to meeting position * added debug messages to meeting position call on Attack.pm * changed route start location to pos_to * fix typo in meetingposition * test using pos_to in canReachMeele instead of calcPos (mimic client?)) * update XSTools and NetRedirect compiled using python 2.7 and perl 5.12 * add .weight to gitignore * fix attack distance check * fix some melee and ranged checks in attack.pm * check if we can attack monster before of trying to move again * add support to maxdistance in skillblock * fix stuck at attack when use slave * update move near slave distance * more fixes to attack distance check * revert check before move * fix distance check * update dlls * change route_step to 10 seems to fix stuck issue * fix meetingposition bug * fix melee reach check and added checkLOS 1 to config * add checkLOS to meele attack * calculate route based in pos not pos_to * Fix reference bug in route.pm solution and incorrect re-increse in step * grammar * recalculate route if we are a long time out * change warning to debug * fix kite code and path, rework attack logic order, fix max path in LOS Co-authored-by: Alison Serafim <10372732+alisonrag@users.noreply.github.com> Co-authored-by: alisonrag <alisonserafim@gmail.com>
* Update SConstruct * remove compiled dll from src/auto * update the compiled dlls
* Add Login Part * Rename File * Update MasterLogin Packet * Wrong Flag in MasterLogin * Del unused * Fix Auto Storage * base packet from Client * Fix autobuy * add xkore mode check / remover blockingPlayerCancel
…penKore#3363) * initial changes * changes * made follow way more responsive, fixed sitauto in follow * removed wrong config conf * fix both plugins
* fix rodex mail list * data is same * struct packet of 0B5F * add send packet
fixed a bug in alertSound in which the conditions "eventList item name1, item name2" did not work
Now building and testing is described in one file. We are using: 1 VM: - Windows Server 2016 - python 2.7 x86 - perl 5.12 x86 (Strawberry) - g++ x86 (Strawberry) - gmake x86 (Strawberry) 2 VM: - Windows Server latest (2019) - python latest (3 x86) - perl 5.32 x86 (Strawberry) - g++ x86 (Strawberry) - gmake x86 (Strawberry) 3 VM: - Ubuntu 18.04 - python 2.7 x64 - perl 5.12 x64 - g++ x64 - make x64 4 VM: - Ubuntu latest (20.04) - python 3 x64 - perl latest x64 (5.32) - g++ x64 - make x64
It was: Month Day Hour:Minute:Second Year.microseconds [Mar 13 01:42:48 2021.11] Loading tables\cities.txt... it became so: Year.Month.Day Hour:Minute:Second.microseconds [2021.03.13 01:42:48 .11] Loading tables\cities.txt...
* merged both meetingPosition into one sub * added a few comments and TODOs * fix grammar
If you have forgotten your account PIN, this plugin will help you recover it.
add "sudo apt update"
updated to version 0.22
Updated: - "checkout" to version 4 - "setup-python" to version 5 - "upload-artifact" to version 4 - "download-artifact" to version 4 - "cache" to version 4
* removed undef %ai_v from ai::clear
alisonrag
previously approved these changes
Oct 23, 2024
Contributor
|
On one hand i don't like this change because we break backward compatibility. EventMacro: we need to decide what name to use next |
Contributor
|
we also use "maxBase" here Why do we use "maxBase" and "minBase" in the "processAutoBuy" function? This function uses the "checkSelfCondition" check, which is included by "maxBase" and "minBase". Need to re-review #2719 |
Contributor
|
Renamed "joblvl" to "jobLvl" for the autoConfChange block We need:
|
alisonrag
approved these changes
Dec 17, 2024
Contributor
|
We are not ready for the merger yet. What are we going to do about this?
|
Contributor
|
Why not leave them both in Misc.pm and only change config.txt? That way backwards compatibility isn't broken and new code can be written with the new sintax |
Contributor
|
I think we haven't used backward compatibility for a long time now to make the code cleaner |
|
actually the wx inteface display the wrong exp block after Lv 230~,or maybe lv 240.. |
Contributor
|
screenshot please |
Contributor
|
I mean the latest packets are using a int64 exp that we are not currently supporting so that could be possible |
|
|
i mean base LV,not job |
Actually, this problem has been going on for a long time. I shouldn’t leave a comment under this post. |
Contributor
|
This issue does not apply to pull requests. |
| disabled 0 | ||
| maxBase | ||
| minBase | ||
| baseLvl |
hexhexD
force-pushed
the
condition-baseLvl
branch
from
dc4cd8e to
c5d7755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will update wiki once this is merged.