Skip to content

Fix stale SME store closures in chat shell #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Apr 9, 2026
Merged

Fix stale SME store closures in chat shell #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions apps/web/src/components/sme/SmeChatShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,12 @@ export function SmeChatShell({
}: SmeChatShellProps) {
const [knowledgePanelOpen, setKnowledgePanelOpen] = useState(false);
const activeConversationId = useSmeStore((s) => s.activeConversationId);
const setConversations = useSmeStore((s) => s.setConversations);
const setDocuments = useSmeStore((s) => s.setDocuments);
const setActiveConversationId = useSmeStore((s) => s.setActiveConversationId);
const appendStreamDelta = useSmeStore((s) => s.appendStreamDelta);
const completeStream = useSmeStore((s) => s.completeStream);
const setMessages = useSmeStore((s) => s.setMessages);

// Load conversations and documents when project changes
useEffect(() => {
const api = ensureNativeApi();
const { setConversations, setDocuments, setActiveConversationId } =
useSmeStore.getState();
void api.sme.listConversations({ projectId: project.id }).then((convs) => {
setConversations(convs as any[]);
});
Expand All @@ -42,7 +38,7 @@ export function SmeChatShell({
});
// Reset active conversation when switching projects
setActiveConversationId(null);
}, [project.id, setConversations, setDocuments, setActiveConversationId]);
}, [project.id]);

// Load messages when active conversation changes
useEffect(() => {
Expand All @@ -52,23 +48,23 @@ export function SmeChatShell({
.getConversation({ conversationId: activeConversationId as SmeConversationId })
.then((result) => {
if (result) {
setMessages(activeConversationId, result.messages as any[]);
useSmeStore.getState().setMessages(activeConversationId, result.messages as any[]);
}
});
}, [activeConversationId, setMessages]);
}, [activeConversationId]);

// Subscribe to SME push events
useEffect(() => {
const api = ensureNativeApi();
const unsubscribe = api.sme.onMessageEvent((event: SmeMessageEvent) => {
if (event.type === "sme.message.delta") {
appendStreamDelta(event.messageId, event.text);
useSmeStore.getState().appendStreamDelta(event.messageId, event.text);
} else if (event.type === "sme.message.complete") {
completeStream(event.messageId, event.text);
useSmeStore.getState().completeStream(event.messageId, event.text);
}
});
return unsubscribe;
}, [appendStreamDelta, completeStream]);
}, []);

return (
<div className="flex min-h-0 flex-1 overflow-hidden">
Expand Down
Loading