Skip to content

Scope desktop preview tabs by thread #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Apr 5, 2026
Merged

Scope desktop preview tabs by thread #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion apps/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const UPDATE_INSTALL_CHANNEL = "desktop:update-install";
const PREVIEW_CREATE_TAB_CHANNEL = "desktop:preview-create-tab";
const PREVIEW_CLOSE_TAB_CHANNEL = "desktop:preview-close-tab";
const PREVIEW_ACTIVATE_TAB_CHANNEL = "desktop:preview-activate-tab";
const PREVIEW_ACTIVATE_THREAD_CHANNEL = "desktop:preview-activate-thread";
const PREVIEW_GO_BACK_CHANNEL = "desktop:preview-go-back";
const PREVIEW_GO_FORWARD_CHANNEL = "desktop:preview-go-forward";
const PREVIEW_RELOAD_CHANNEL = "desktop:preview-reload";
Expand Down Expand Up @@ -1275,18 +1276,29 @@ function registerIpcHandlers(): void {
ipcMain.removeHandler(PREVIEW_CREATE_TAB_CHANNEL);
ipcMain.handle(
PREVIEW_CREATE_TAB_CHANNEL,
async (event, input: { url?: unknown; title?: unknown }) => {
async (event, input: { url?: unknown; title?: unknown; threadId?: unknown }) => {
const window = resolvePreviewWindow(event.sender);
if (!window) {
return { tabId: "", state: createEmptyTabsState() };
}
return getPreviewController(window).createTab({
url: input?.url,
title: input?.title,
threadId: input?.threadId,
});
},
);

ipcMain.removeHandler(PREVIEW_ACTIVATE_THREAD_CHANNEL);
ipcMain.handle(
PREVIEW_ACTIVATE_THREAD_CHANNEL,
async (event, input: { threadId?: string }) => {
const window = resolvePreviewWindow(event.sender);
if (!window || !input?.threadId) return createEmptyTabsState();
return getPreviewController(window).activateThread(input.threadId);
},
);

ipcMain.removeHandler(PREVIEW_CLOSE_TAB_CHANNEL);
ipcMain.handle(PREVIEW_CLOSE_TAB_CHANNEL, async (event, input: { tabId?: PreviewTabId }) => {
const window = resolvePreviewWindow(event.sender);
Expand Down
2 changes: 2 additions & 0 deletions apps/desktop/src/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const UPDATE_INSTALL_CHANNEL = "desktop:update-install";
const PREVIEW_CREATE_TAB_CHANNEL = "desktop:preview-create-tab";
const PREVIEW_CLOSE_TAB_CHANNEL = "desktop:preview-close-tab";
const PREVIEW_ACTIVATE_TAB_CHANNEL = "desktop:preview-activate-tab";
const PREVIEW_ACTIVATE_THREAD_CHANNEL = "desktop:preview-activate-thread";
const PREVIEW_GO_BACK_CHANNEL = "desktop:preview-go-back";
const PREVIEW_GO_FORWARD_CHANNEL = "desktop:preview-go-forward";
const PREVIEW_RELOAD_CHANNEL = "desktop:preview-reload";
Expand Down Expand Up @@ -63,6 +64,7 @@ contextBridge.exposeInMainWorld("desktopBridge", {
createTab: (input) => ipcRenderer.invoke(PREVIEW_CREATE_TAB_CHANNEL, input),
closeTab: (input) => ipcRenderer.invoke(PREVIEW_CLOSE_TAB_CHANNEL, input),
activateTab: (input) => ipcRenderer.invoke(PREVIEW_ACTIVATE_TAB_CHANNEL, input),
activateThread: (input) => ipcRenderer.invoke(PREVIEW_ACTIVATE_THREAD_CHANNEL, input),
goBack: () => ipcRenderer.invoke(PREVIEW_GO_BACK_CHANNEL),
goForward: () => ipcRenderer.invoke(PREVIEW_GO_FORWARD_CHANNEL),
reload: () => ipcRenderer.invoke(PREVIEW_RELOAD_CHANNEL),
Expand Down
Loading
Loading