Java 8u261 added support for TLS1.3, avoid assuming otherwise #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonygermano
reviewed
Jul 29, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
Can we get rid of the java version check and always assertTrue? I am not worried about the tests failing if they are run on a too old version of java 8 since we are working to completely remove java 8 support, anyway.
kpalang
requested review from
a team,
gibson9583,
kayyagari,
kpalang and
tonygermano
and removed request for
a team
jonbartels
approved these changes
Aug 15, 2025
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
jonbartels
force-pushed
the
maint/fix-tls13test
branch
from
ca21f1e to
7ecf54b
Compare
kayyagari
approved these changes
Aug 15, 2025
kpalang
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #144