fix: mirror claude-code supports_set_session_model=true#206
Draft
simonrosenberg wants to merge 1 commit into
Draft
fix: mirror claude-code supports_set_session_model=true#206simonrosenberg wants to merge 1 commit into
simonrosenberg wants to merge 1 commit into
Conversation
Mirrors OpenHands/software-agent-sdk#3655 (claude-agent-acp 0.30.0 ignores _meta-based initial model selection; init now uses session/set_model). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mirrors OpenHands/software-agent-sdk#3655: claude-agent-acp 0.30.0 silently ignores the
_meta-based initial model selection (software-agent-sdk#3654), so the SDK now applies the claude-code initial model viasession/set_modeland flipssupports_set_session_modeltotruein the registry. This repo's JSON mirror must match field-for-field or thevalidate-acp-providersdrift job blocks all PRs.Summary
claude-code.supports_set_session_model:false→trueinsrc/models/acp-providers.json(one line; codex/gemini untouched).Issue Number
OpenHands/software-agent-sdk#3654
How to Test
npm test→ all suites pass.validate-acp-providerscompares against SDK main and stays red until fix(sdk): apply claude-code initial ACP model via set_session_model (claude-agent-acp ignores _meta) software-agent-sdk#3655 merges; verified green locally against that branch:🤖 Generated with Claude Code