Skip to content

Fix _GatedLLM.completion override after _return_metrics removal #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VascoSch92 wants to merge 1 commit into from
+0 −2
Closed

Fix _GatedLLM.completion override after _return_metrics removal #3794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/agent_server/test_goal_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def completion(
self,
messages,
tools=None,
_return_metrics=False,
add_security_risk_prediction=False,

@all-hands-bot all-hands-bot Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical: Functional QA shows this override no longer accepts the current TestLLM.completion positional signature in this PR's base. Calling _GatedLLM.completion(messages, None, False, True, on_token) succeeds on the base commit but raises TypeError: _GatedLLM.completion() takes from 2 to 5 positional arguments but 6 were given on this head. The existing CI pyright log reports the same mismatch: the base method still has _return_metrics in this PR context, so this change does not achieve the stated goal.

This inline finding was created by an AI agent (OpenHands) on behalf of the user.

on_token=None,
**kwargs,
Expand All @@ -53,7 +52,6 @@ def completion(
return super().completion(
messages,
tools,
_return_metrics,
add_security_risk_prediction,
on_token,
**kwargs,
Expand Down
Loading