docs(acp): deprecate acp_env; route env/credentials through conversation secrets#544
Merged
Conversation
…ion secrets ACPAgent.acp_env was deprecated in software-agent-sdk 1.24.0 (removal 1.29.0). Update the ACP guide to stop recommending it: - drop acp_env from the configuration example and mark it deprecated in the parameter table, pointing to the conversation's secrets / agent_context.secrets - add an "Environment Variables and Credentials" section showing the Conversation(secrets=...) channel - fix the AgentContext compatibility table: agent_context.secrets is now acp_compatible (injected into the subprocess env), not a NotImplementedError Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
enyst
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ACPAgent.acp_envwas deprecated in software-agent-sdk 1.24.0 (removal in 1.29.0; see OpenHands/software-agent-sdk#3464). The ACP guide still recommended it for credentials (acp_env={"ANTHROPIC_API_KEY": "sk-..."}), and separately claimedAgentContext.secretsis ACP-incompatible / raisesNotImplementedError— which is now the recommended replacement channel, so the page contradicted itself.Changes (
sdk/guides/agent-acp.mdx)acp_envfrom the configuration example; mark it Deprecated (removed in 1.29.0) in the parameter table, pointing to the conversation'ssecrets/agent_context.secrets.Conversation(agent=..., workspace=..., secrets={...})— the canonical channel that flows into the secret registry and is injected into the ACP subprocess env.secretsis nowacp_compatible: True(injected into the subprocess env, and masked if echoed back — fix(acp): mask injected secrets in tool-call output and streamed text software-agent-sdk#3463), not aNotImplementedError.llms.txt/llms-full.txtare regenerated by the scheduledSync llms context filesworkflow, so they're intentionally not touched here.🤖 Generated with Claude Code