fix: show conversations in collapsed sidebar#1398
Open
YfengJ wants to merge 1 commit into
Open
Conversation
|
@YfengJ is attempting to deploy a commit to the openhands Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
Needs human manual UI testing before this checkbox can be checked.
AGENT:
I reproduced the code path from issue #1194:
SidebarRailBodyalways passes the collapsed state toSidebarConversationList, butSidebarConversationListreturnednullwhen collapsed, removing the conversation picker entirely. This PR routes the collapsed state into the existing compact conversation panel/row UI and adds a regression step to the mock-LLM conversation flow.Why
When the desktop sidebar is collapsed, users should still be able to select an existing conversation without expanding the sidebar first. The current collapsed render path removes the conversation list entirely.
Summary
ConversationPanelin compact mode inside the collapsed sidebar instead of returningnull.Issue Number
Fixes #1194
How to Test
Agent-run checks:
npm run lintnpm run build:appManual UI test steps for a reviewer:
npm cinpm run dev:mockAttempted full mock-LLM e2e locally with:
env -u http_proxy -u https_proxy -u all_proxy NO_PROXY=localhost,127.0.0.1,::1 DEBUG=pw:webserver npm run test:e2e:mock-llm -- conversations/mock-llm-conversation.spec.tsThat full-stack local run could not start because the local Python mock-LLM server was missing the
openhandsSDK module.Video/Screenshots
Not provided. The compact row behavior is covered by the added e2e regression step, but the local full-stack e2e environment was blocked before the browser flow could start.
Type
Notes
The Vercel preview check currently requires OpenHands team authorization for this forked PR.