Add Model Router (meta-profiles) settings tab by juanmichelini · Pull Request #1395 · OpenHands/agent-canvas

juanmichelini · 2026-06-16T19:48:01Z

Summary

Adds a new Model Router settings page (/settings/meta-llm) for managing meta-profiles — declarative model-routing configurations consumed by the agent's classify_and_switch_llm tool. A meta-profile names a classifier_model, a default_model, and a list of task classes, each referencing a saved LLM profile.

Previously meta-profiles could only be set via PATCH /api/settings; this exposes full list/get/save/delete/activate management in the UI, mirroring the existing LLM Profiles experience.

What's included

MetaProfilesService — client over the new /api/meta-profiles endpoints (built on the SDK's public HttpClient, mirroring ProfilesClient).
Query/mutation hooks — useMetaProfiles, plus useSaveMetaProfile / useDeleteMetaProfile / useActivateMetaProfile. Activate also refreshes the settings cache, since it flips active_meta_profile (which controls whether classify_and_switch_llm is attached to new conversations).
UI — list view with- UI e badge and a ... overflow menu (Edit / Set active / Delete, matching /settings/llm), a create/edit editor (name, classifier model, default model, dynamic task-class rows with profile-name dropdowns sourced from saved LLM profiles), and a delete-confirmation modal.
Wiring — nav entry, route, and i18n strings (all languages filled per the repo's completeness check).
Local-backend only — cloud backends show an explanatory message, matching LLM-profiles behavior.

Testing

12 component tests (list/empty states, add → editor, activate & edit via the actions menu, disabled "Set active" for the active profile, editor validation/add-remove class/cancel).
tsc, eslint, prettier, and the i18n duplicate-key / completeness checks all pass.
Verified the backend contract end-to-end over real HTTP (list/create/get/activate/delete + 404/422) against a local SDK checkout.

Dependency

Requires the meta-profile CRUD API (/api/meta-profiles) added in software-agent-sdk PR #3744. Until that ships, the page renders but the list query returns 404.

Shared client types (review follow-up)

Per review feedback, the meta-profile interfaces and HTTP wiring should live in the shared SDK client rather than being redefined here. Those types and a dedicated MetaProfilesClient (mirroring ProfilesClient) have been added in typescript-client PR #212. Once that lands and is released, this PR will bump @openhands/typescript-client and refactor MetaProfilesService to import the types + client from the package (dropping the local interfaces and the raw HttpClient usage), exactly as ProfilesService does today. The interim local definitions are kept only so the page compiles against the currently-published client.

Review fixes (commit `ade0bf9`)

Addressed review feedback on the create-flow semantics and the
compatibility boundary:

Create can no longer silently overwrite an existing meta-profile.
The backend save is create-or-overwrite, and create mode previously
validated only name syntax. MetaProfileEditor now takes
existingNames and, in create mode, rejects a name that already exists:
Save is disabled and an explicit "name already exists" message is shown
(meta-profile-name-taken). Edit mode is unchanged.
The unsupported-backend boundary is now explicit instead of a dead
page. On backends that predate the /api/meta-profiles endpoints
(software-agent-sdk #3744) the list query returns 404; the view now
detects HttpError.status === 404 and renders a clear "this backend
doesn't support model routing yet" message (meta-profile-unsupported)
and hides the Add affordance. Non-404 errors still show the generic
error with Add available.
Deleting the active meta-profile now invalidates the settings caches
(SettingsService.invalidateCache + SETTINGS_QUERY_KEYS.personal),
mirroring activation — active_meta_profile controls whether
classify_and_switch_llm attaches to new conversations, so the prior
behavior could leave settings stale until reload.

New tests covering the previously-uncovered risks:

editor: duplicate-name rejected in create mode (Save blocked, no
onSave), unique name accepted, and edit-mode name still allowed.
view: 404 → explicit unsupported message and no Add button;
500 → generic error with Add still present.
hook: useDeleteMetaProfile invalidates the meta-profile and
settings caches on success.

i18n: added SETTINGS$META_PROFILE_NAME_TAKEN and
SETTINGS$META_PROFILE_UNSUPPORTED across all locales.

Merge note (lockstep): this page depends on software-agent-sdk
#3744. The agentServer pin in config/defaults.json should be bumped
to a release that includes those endpoints in lockstep with merging
this PR; until then the page degrades gracefully to the unsupported
message above rather than a generic error.

This PR was created by an AI agent (OpenHands) on behalf of @juanmichelini.

Adds a /settings/meta-llm page for managing meta-profiles — declarative model-routing configs consumed by the agent's classify_and_switch_llm tool. A meta-profile names a classifier_model, a default_model and a list of task classes, each referencing a saved LLM profile. - MetaProfilesService over the new /api/meta-profiles endpoints (driven by the SDK's public HttpClient, mirroring ProfilesClient) - useMetaProfiles query + save/delete/activate mutations - List/create/edit view with profile-name dropdowns sourced from saved LLM profiles, plus a delete confirmation modal - Nav entry, route, and i18n strings (all languages filled per repo policy) - Local-backend only (cloud shows an explanatory message) Requires the meta-profile CRUD API from software-agent-sdk #3744. Co-authored-by: openhands <openhands@all-hands.dev>

Match the LLM profiles page: replace the inline Set active / Edit / Delete buttons with an EllipsisButton trigger + portaled actions menu (MetaProfileActionsMenu), reusing the shared settings-list row styling (MetaProfileRow). Set active is disabled for the already-active profile. Co-authored-by: openhands <openhands@all-hands.dev>

vercel · 2026-06-16T19:48:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agent-canvas	Ready	Preview, Comment	Jun 16, 2026 8:36pm

Frontend review fixes for the Model Router settings tab: 1. Create flow could silently overwrite an existing meta-profile (the backend save is create-or-overwrite). MetaProfileEditor now takes `existingNames` and, in create mode, rejects a name that already exists: Save is disabled and an explicit "name already exists" message is shown. Edit mode is unaffected (the current name stays valid). 2. Unsupported-backend boundary is now explicit. Older agent servers (pre software-agent-sdk #3744) lack /api/meta-profiles and return 404; the view detects that (HttpError.status === 404) and shows a clear "backend doesn't support model routing yet" message instead of a generic error, and hides the Add affordance. Non-404 errors still show the generic error with Add available. 3. Deleting the active meta-profile now invalidates the settings caches (SettingsService.invalidateCache + SETTINGS_QUERY_KEYS.personal), mirroring activation — active_meta_profile controls whether classify_and_switch_llm attaches to new conversations, so stale settings could otherwise linger until reload. Tests: - editor: duplicate-name rejection (create) + unique-name acceptance + edit-mode name allowed. - view: 404 -> explicit unsupported message and no Add; 500 -> generic error with Add. - new hook test: delete invalidates meta-profile AND settings caches. i18n: add SETTINGS$META_PROFILE_NAME_TAKEN and SETTINGS$META_PROFILE_UNSUPPORTED across all locales. Co-authored-by: openhands <openhands@all-hands.dev>

all-hands-bot · 2026-06-16T21:22:38Z

✅ Review complete.

This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here.

all-hands-bot

Code Review: Add Model Router (meta-profiles) settings tab

🟢 Good taste — Clean, well-structured PR. Good separation of concerns across API service, hooks, and UI components. TanStack Query integration is solid with proper cache invalidation. Test coverage is comprehensive for the main user-facing flows.

Summary

This PR adds a new settings tab for managing meta-profiles — declarative model-routing configurations consumed by the classify_and_switch_llm tool. The implementation includes:

API layer: MetaProfilesService wrapping /api/meta-profiles endpoints
Data layer: TanStack Query hooks with proper cache management
UI layer: Settings view, profile editor, row components, and actions menu
Integration: Routes, navigation, and i18n translations
Tests: Component and hook tests with good coverage

Key Strengths

Clean API design: The service mirrors existing patterns (ProfilesClient) and handles the backend API correctly with proper typing
Proper cache invalidation: useActivateMetaProfile and useDeleteMetaProfile invalidate both meta-profiles and settings caches, which is correct since activation/deletion affects conversation behavior
Good error handling: 404 detection for unsupported backends provides a clear user message instead of a generic error
Testable architecture: Good use of mocks and isolated component testing
Duplicate name prevention: The MetaProfileEditor correctly blocks creating a profile with an existing name (the backend uses create-or-overwrite semantics)

Minor Suggestions

File	Line	Suggestion
`src/components/features/settings/meta-llm-profiles/meta-profile-actions-menu.tsx`	~1044	`useLayoutEffect` is used for scroll/resize listeners. Consider whether `useEffect` would suffice here — `useLayoutEffect` is only needed when you need to measure DOM before paint. If position calculation doesn't affect initial paint, `useEffect` avoids potential hydration issues.
`__tests__/hooks/mutation/`	—	Tests exist for `useDeleteMetaProfile` but not for `useSaveMetaProfile` or `useActivateMetaProfile`. Consider adding tests for these hooks to match coverage.

Testing Verification

Component tests cover: list view, empty state, editor open/create, activation, edit loading, unsupported backend (404), and duplicate name rejection
Hook test covers: delete with cache invalidation

Risk Assessment

⚠️ Risk Assessment: 🟢 LOW

Purely additive changes with no breaking modifications
Backend API is optional (404 handling is present)
No new external dependencies
Cloud vs local backend is properly gated in the route

This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation

malhotra5 · 2026-06-16T21:40:50Z

+  model: string;
+}
+
+export interface MetaProfile {


Can we move these interfaces to openhands/typescript-client

@malhotra5 is it okay if I release a tag of openhands/typescript-client, so I can merge this one?

yep thats okay!

please release as you need

openhands-agent added 2 commits June 16, 2026 15:45

vercel Bot deployed to Preview June 16, 2026 19:48 View deployment

juanmichelini mentioned this pull request Jun 16, 2026

Intelligent model router: classify_and_switch_llm tool + meta-profiles OpenHands/software-agent-sdk#3744

Open

6 tasks

vercel Bot deployed to Preview June 16, 2026 20:36 View deployment

juanmichelini requested a review from all-hands-bot June 16, 2026 21:21

all-hands-bot approved these changes Jun 16, 2026

View reviewed changes

malhotra5 reviewed Jun 16, 2026

View reviewed changes

juanmichelini mentioned this pull request Jun 17, 2026

feat: add MetaProfilesClient and meta-profile types OpenHands/typescript-client#212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Model Router (meta-profiles) settings tab#1395

Add Model Router (meta-profiles) settings tab#1395
juanmichelini wants to merge 3 commits into
mainfrom
feat/meta-llm-settings-tab

juanmichelini commented Jun 16, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

all-hands-bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

all-hands-bot left a comment

Uh oh!

malhotra5 Jun 16, 2026

Uh oh!

juanmichelini Jun 17, 2026

Uh oh!

malhotra5 Jun 17, 2026

Uh oh!

malhotra5 Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

juanmichelini commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What's included

Testing

Dependency

Shared client types (review follow-up)

Review fixes (commit ade0bf9)

Uh oh!

vercel Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

all-hands-bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

all-hands-bot left a comment

Choose a reason for hiding this comment

Code Review: Add Model Router (meta-profiles) settings tab

Summary

Key Strengths

Minor Suggestions

Testing Verification

Risk Assessment

Uh oh!

malhotra5 Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

juanmichelini Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

malhotra5 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

malhotra5 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juanmichelini commented Jun 16, 2026 •

edited

Loading

Review fixes (commit `ade0bf9`)

vercel Bot commented Jun 16, 2026 •

edited

Loading

all-hands-bot commented Jun 16, 2026 •

edited

Loading