refactor(shared): extract TOOL_KIND_MAPPING to shared module#778
Open
github-actions[bot] wants to merge 1 commit into
Open
refactor(shared): extract TOOL_KIND_MAPPING to shared module#778github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Move the TOOL_KIND_MAPPING constant from acp_impl/events/utils.py to shared/tool_kinds.py to centralize tool kind definitions and reduce code duplication. Addresses item from code quality report. Closes #777 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the
TOOL_KIND_MAPPINGconstant fromacp_impl/events/utils.pyto a newshared/tool_kinds.pymodule to centralize tool kind definitions and reduce code duplication.Changes
openhands_cli/shared/tool_kinds.pywith the shared constantacp_impl/events/utils.pyto import from shared moduleacp_impl/events/tool_state.pyto import from shared moduleshared/__init__.pyto export the constantRelated Issue
Addresses findings from #777
Testing
make lint)make test- 1357 tests)This PR was automatically generated by the Code Quality Report workflow.