fix(shared): add shared Console singletons to reduce instance creation#763
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(shared): add shared Console singletons to reduce instance creation#763github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Addresses item from code quality report. - Created openhands_cli/shared/console.py with shared console and stderr_console - Updated 6 files to use shared singletons instead of creating local instances: - agent_store.py: module-level and inline Console() replaced - entrypoint.py: module-level Console() replaced - gui_launcher.py: module-level Console() replaced - conversations/viewer.py: module-level Console() replaced - conversations/display.py: module-level Console() replaced - mcp/mcp_commands.py: module-level Console() replaced Closes #761 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shared Console singletons (
consoleandstderr_console) inopenhands_cli/shared/console.pyto avoid creating multiple Console instances throughout the codebase.Changes
openhands_cli/shared/console.pywith shared console instancesagent_store.py: module-level and inlineConsole()replacedentrypoint.py: module-levelConsole()replacedgui_launcher.py: module-levelConsole()replacedconversations/viewer.py: module-levelConsole()replacedconversations/display.py: module-levelConsole()replacedmcp/mcp_commands.py: module-levelConsole()replacedRelated Issue
Addresses findings from #761 (Code Quality Report - Low-Hanging Fruit)
Testing
make lint)make test- 1353 tests)This PR was automatically generated by the Code Quality Report workflow.