auth: tolerate settings sync failures after login#726
Draft
xingyaoww wants to merge 1 commit into
Draft
Conversation
Contributor
Contributor
|
This PR is stale because it has been open for 40 days with no activity. Remove the stale label or leave a comment, otherwise it will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Refs #725. This hardens the login flow against settings endpoint failures, but the reproduced local traceback is from the currently published
openhandswheel, which still contains the pre-#711 auth client that calls/api/settingsand depends onopenhands-sdk==1.19.1.The current
mainbranch already calls/api/v1/settingsand depends onopenhands-sdk==1.21.0, but the CLI package version remains1.15.1, soopenhands --versionalone does not distinguish the stale PyPI wheel from the current checkout.Tests
make lintmake test