Skip to content

auth: tolerate settings sync failures after login#726

Draft
xingyaoww wants to merge 1 commit into
mainfrom
fix-login-settings-sync
Draft

auth: tolerate settings sync failures after login#726
xingyaoww wants to merge 1 commit into
mainfrom
fix-login-settings-sync

Conversation

@xingyaoww

@xingyaoww xingyaoww commented May 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Treat settings sync API errors as a warning after OAuth instead of failing the post-login data fetch.
  • Skip local agent configuration when settings cannot be fetched, while preserving the retrieved LLM key in the returned data.
  • Add regression coverage for settings API failures during post-OAuth user data fetch.

Context

Refs #725. This hardens the login flow against settings endpoint failures, but the reproduced local traceback is from the currently published openhands wheel, which still contains the pre-#711 auth client that calls /api/settings and depends on openhands-sdk==1.19.1.

The current main branch already calls /api/v1/settings and depends on openhands-sdk==1.21.0, but the CLI package version remains 1.15.1, so openhands --version alone does not distinguish the stale PyPI wheel from the current checkout.

Tests

  • make lint
  • make test

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report •
FileStmtsMissCoverMissing
openhands_cli/auth
   api_client.py1591391%44, 138, 174, 221, 230, 245–246, 266, 270, 297, 358–360
TOTAL681596785% 

@xingyaoww xingyaoww changed the title auth: keep login successful when settings sync fails auth: tolerate settings sync failures after login May 8, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 40 days with no activity. Remove the stale label or leave a comment, otherwise it will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant