-
Notifications
You must be signed in to change notification settings - Fork 10
update cli docs for clarity and accuracy #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things, otherwise it looks good to me.
|
|
||
| This opens an interactive viewer. You can move the ligand names around to get a | ||
| better view of the structure, and if you click on the edge, you will see the | ||
| to open an interactive viewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to the sentence on line 93? It feels a bit jarring to just have the end of a sentence after the method is being shown.
| ``` | ||
|
|
||
| Let's assume you want to exchange the kartograf atom mapper with the LOMAP atom mapper, the Minimal Spanning Tree | ||
| Network Planner with the Maximal Network Planner and the am1bcc charge method with [OpenFF NAGL](https://docs.openforcefield.org/projects/nagl/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping into 1/2/3 seems to be missing something here. Maybe in this sentence you should something like "to achieve this, you would do the following N steps:"
| want to create a new job script for each simulation JSON file, and the core of | ||
| that job script will be to run the `openfe quickrun` command above. | ||
| When running a complete network of simulations, it is important to ensure that the file name for the result JSON and name of the working directory are different for each leg and each repeat, otherwise you'll overwrite results. | ||
| We recommend doing this programmatically, such as the example below, which uses the fact that the JSON files in `network_setup/transformations/` have unique names, and creates directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to just have the slurm example be the one that shows this off. Partly this is because a lot of folks just don't have any clue about slurm. I would re-add the bash example that demonstrates how to do this and loop over all the files.
this is likely where users will start, so we should make sure it's up to date and clear!