Skip to content

fix: satisfy clippy for external adapter code #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
Jun 6, 2026
Merged

fix: satisfy clippy for external adapter code #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/coven-cli/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,11 +473,12 @@ fn session_launch_from_payload(payload: Value) -> Result<SessionLaunch> {
// instead of letting the runtime's arg builder surface it later as a
// 500. Bonus: rejecting here means we never insert a session row for
// a launch that can't possibly succeed.
let supported: Vec<String> = crate::harness::configured_harness_specs()?
.into_iter()
.map(|spec| spec.id)
let supported_specs = crate::harness::configured_harness_specs()?;
let supported: Vec<&str> = supported_specs
.iter()
.map(|spec| spec.id.as_str())
.collect();
if !supported.contains(&harness) {
if !supported.contains(&harness.as_str()) {
anyhow::bail!(
"harness `{harness}` is not a supported harness; expected one of {supported:?}"
);
Expand Down