fix(ci): restrict auto-release marker to release bot#44
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the security of the commit-marker-driven release automation by ensuring the auto-release job can only execute when the workflow run is triggered by a single trusted actor (opencoven-bot), preventing contributor-controlled PR titles/commit messages from indirectly authorizing a release on merge.
Changes:
- Add a job-level actor guard to
auto-release(if: github.actor == 'opencoven-bot'). - Update workflow header comments to document that the
--releasemarker path is restricted to the trusted release bot. - Add an inline comment explaining the threat model (marker injection via merged PRs) and why the guard exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
if: github.actor == 'opencoven-bot'to theauto-releasejob and update workflow comments in.github/workflows/auto-release.ymlso only the trusted release bot can trigger the commit-marker release path.Testing
python - <<'PY' ... PYwhich passed.ruby -e "require 'yaml'; YAML.load_file('.github/workflows/auto-release.yml')"which passed.git diff --check -- .github/workflows/auto-release.ymlto verify no whitespace/format errors, which passed.Codex Task