Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes streaming performance through adaptive input polling, decoupled diagnostics, and real-time lag classification.
Performance Improvements
Adaptive polling
Decoupled diagnostics
useSyncExternalStoreto eliminate React re-renders from 500ms stats pollingStreamViewandAppsubscribe directly to the store instead of props drilling stats through the component treeLag classification
Changes
src/renderer/src/gfn/webrtcClient.ts
StreamLagReasontype andlagReason/lagReasonDetailtoStreamDiagnosticsclassifyLagReason()for automatic bottleneck detectionscheduleGamepadPolling()andgetGamepadPollIntervalMs()src/renderer/src/utils/streamDiagnosticsStore.ts (new)
createStreamDiagnosticsStore()anduseStreamDiagnosticsStore()hookuseSyncExternalStorefor efficient subscriptions without React re-renderssrc/renderer/src/App.tsx
setDiagnosticsstate withdiagnosticsStoreexternal storeStreamView; components now subscribe directlysrc/renderer/src/components/StreamView.tsx
useStreamDiagnosticsStore()hooksetTimeoutloop with reduced FFT sizesrc/renderer/src/components/StatsOverlay.tsx