Skip to content

Various fixups for docker-build-release#7

Merged
rainest merged 2 commits into
mainfrom
feature/multi-arch-build-refinements
Jun 1, 2026
Merged

Various fixups for docker-build-release#7
rainest merged 2 commits into
mainfrom
feature/multi-arch-build-refinements

Conversation

@alexlovelltroy
Copy link
Copy Markdown
Member

  • Removed the duplicate actions/attest-build-provenance@v3 step. The docker/build-push-action@v6 already generates provenance and SBOM attestations that work correctly with multi-arch manifest lists.
  • Use conditional expression to only pass CC when it's not empty
  • Added Image Description Support

For more info, see Contributing Guidelines.

- Removed the duplicate `actions/attest-build-provenance@v3` step. The `docker/build-push-action@v6` already generates provenance and SBOM attestations that work correctly with multi-arch manifest lists.
- Use conditional expression to only pass CC when it's not empty
- Added Image Description Support

Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
@alexlovelltroy alexlovelltroy requested a review from rainest June 1, 2026 17:56
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Copy link
Copy Markdown
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is busted, but AFAICT we're stuck using test repos to properly test here anyway.

To that end: https://github.com/rainest/power-control/actions/runs/26782021013

The unknown/unknown thing is still there. That's apparently a GitHub bug that they can't be bothered to fix per https://github.com/orgs/community/discussions/45969

Discussion lists disabling attestations as a workaround, but we do want those, and it looks like the phantom OS/arch entry is otherwise benign, so 🤷

Also GitHub has helpfully dumped a spoopy "Node update's coming oh no 👻 " warning that you can't actually clear even if you test with it on: see https://github.com/orgs/community/discussions/190988 and https://github.com/rainest/power-control/actions/runs/26782487730

@rainest rainest merged commit 4faffe3 into main Jun 1, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants