Remove sensitive XML attributes (password/pwd) in REST API responses#467
Closed
apeiris wants to merge 2 commits into
Closed
Remove sensitive XML attributes (password/pwd) in REST API responses#467apeiris wants to merge 2 commits into
apeiris wants to merge 2 commits into
Conversation
- Introduced /getPropertyList endpoint returning application properties as JSON. - Introduced /getXml endpoint returning XML content filtered via XPath. - Added HTTPS enforcement for non-localhost requests to prevent exposure of sensitive information. - Implemented isLocalhost(Request) helper for local testing exceptions. - Added XML parsing with XXE protection. - Updated imports and cleaned up unused imports.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| @GET | ||
| @RolesAllowed({"ADMIN"}) |
Check failure
Code scanning / CodeQL
XPath injection Critical
Contributor
Author
|
Closing to resolve CodeQL issue |
Contributor
Author
|
Closing to resolve CodeQL issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove any sensitive entries (password/pwd) returned from Properties.getProperties() in getPropertyList().
Updated getXml() to recursively redact sensitive XML attributes (password or pwd) before returning the XML response.
Introduced redactSensitiveAttributes(Node node) helper method to traverse nodes and remove sensitive attributes.