Add secure property and XML retrieval endpoints to ApiResource#465
Closed
apeiris wants to merge 1 commit into
Closed
Add secure property and XML retrieval endpoints to ApiResource#465apeiris wants to merge 1 commit into
apeiris wants to merge 1 commit into
Conversation
- Introduced /getPropertyList endpoint returning application properties as JSON. - Introduced /getXml endpoint returning XML content filtered via XPath. - Added HTTPS enforcement for non-localhost requests to prevent exposure of sensitive information. - Implemented isLocalhost(Request) helper for local testing exceptions. - Added XML parsing with XXE protection. - Updated imports and cleaned up unused imports.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| Session session = getProcessor().getSession(); | ||
| String filePath = session.getBaseDirectory() + "/" + filename; | ||
| try { |
Check failure
Code scanning / CodeQL
XPath injection Critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Add secure property and XML retrieval endpoints to ApiResource
Description:
This pull request introduces two new administrative endpoints in
ApiResourceand enforces security measures to prevent sensitive information exposure:Changes:
/getPropertyListendpoint:ADMINrole.403 FORBIDDENis returned./getXmlendpoint:ADMINrole.403 FORBIDDENis returned.Security enhancements:
isLocalhost(Request)helper allows local testing while enforcing HTTPS for remote clients.Other updates:
Notes:
If you want, I can also draft a shorter, GitHub-friendly one-paragraph version suitable for casual PR reviews. Do you want me to do that?