Prepare code for clang-tidy-22#1106
Open
andrsd wants to merge 11 commits into
Open
Conversation
Fixing clang-tidy warning
`std::atoi` provides no error handling at all; if the string is completely invalid, it just returns 0, and if the number overflows, the behavior is undefined.
clang-tidy-22 reports that as an error now.
- default ctor gives truly random behavior - ctor with seed should be used for reproducible results (for example in a test suite)
andrsd
force-pushed
the
fix-clang-tidy-22-issues
branch
from
4e622f0 to
7663003
Compare
Collaborator
Author
|
Personally, I would drop Also |
andrsd
force-pushed
the
fix-clang-tidy-22-issues
branch
from
7663003 to
92ceb4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist