fix(asr): 修复 Apple Speech 听写误走火山路径#741
Open
snvtac wants to merge 1 commit into
Open
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
Fixes #731。
修复 macOS Apple Speech ASR 在普通听写启动时仍落入火山引擎凭据 / WebSocket 路径的问题。
修复 / 新增 / 改进
apple-speech纳入无外部凭据的本地 ASR provider 门禁,macOS 直接放行,非 macOS 返回明确平台错误。ActiveAsr::AppleSpeech,不再进入 Volcengine fallback。apple-speech与local-qwen3的本地路径选择。兼容
apple-speech的 macOS 用户;其他 ASR provider 路径保持不变。测试计划
git diff --checkcargo test --lib macos_keyless_dictation_provider_routes_apple_speech_locallycargo test --lib qa_asr_provider_kind_tracks_active_providercargo test --lib local_asr_providers_skip_external_validationcargo test有仓库既有 unused/deprecated warning,未发现本次改动相关失败。PR Type
Bug fix, Enhancement
Description
Add Apple Speech to local ASR credential gate
Route Apple Speech dictation locally on macOS
Unify local dictation providers with enum
Diagram Walkthrough
flowchart LR A["active_asr"] --> B{"is apple-speech?"} B -- yes --> C["credential gate: macOS -> Ok"] C --> D["begin_session_as: apple-speech local branch"] B -- no --> E["existing paths (volcengine, bailian, etc.)"]File Walkthrough
asr_wiring.rs
Add Apple Speech to credential gateopenless-all/app/src-tauri/src/coordinator/asr_wiring.rs
checks
dictation.rs
Route Apple Speech dictation locallyopenless-all/app/src-tauri/src/coordinator/dictation.rs
MacosKeylessDictationProviderenummacos_keyless_dictation_providerfunctionbegin_session_as