refine_flowvision by JensenPL · Pull Request #216 · Oneflow-Inc/vision

JensenPL · 2022-04-29T06:35:27Z

No description provided.

doombeaker · 2022-04-29T06:39:46Z

docs/source/flowvision.models.rst

 ==============

-The models subpackage contains definitions for the following model
+The models' subpackage contains definitions for the following model


这个修改是错的，你可能没有去理解原文意思？

doombeaker · 2022-04-29T06:40:23Z

docs/source/tutorials/Getting Started.md

 ## Usage
 ### Create a model
-In flowvision we support two ways to create a model.
+Flowvision supports two ways to create a model:


Suggested change

Flowvision supports two ways to create a model:

FlowVision supports two ways to create a model:

doombeaker · 2022-04-29T06:41:04Z

docs/source/tutorials/Getting Started.md

 ```

-### Search for supported model by Wildcard
+### Search for the supported model by Wildcard


这里的大小写是遵循什么规范呢，为什么 "Wildcard“ 是单独大写的。

doombeaker · 2022-04-29T06:41:55Z

flowvision/data/mixup.py

 def rand_bbox(img_shape, lam, margin=0.0, count=None):
    """ Standard CutMix bounding-box
-    Generates a random square bbox based on lambda value. This impl includes
+    generates a random square bbox based on lambda value. This impl includes


Suggested change

generates a random square bbox based on lambda value. This impl includes

generates a random square bbox based on lambda value. This implementation includes

impl 是什么意思？

rentainhe · 2022-05-04T16:55:08Z

flowvision/data/auto_augment.py

 def auto_augment_transform(config_str, hparams):
    """
-    Create a AutoAugment transform
+    Creates a AutoAugment transform


这边需要Creates吗2333，我怎么感觉貌似Create就行了

rentainhe · 2022-05-04T16:56:01Z

flowvision/data/mixup.py

 def mixup_target(target, num_classes, lam=1.0, smoothing=0.0, device="cuda"):
    """
-    Mixup the targets with label-smoothing
+    Mixes up the targets with label-smoothing


这边用MixUp就行了，mixup整体是作为一个名词，表示一个数据增强操作

rentainhe · 2022-05-04T16:57:52Z

flowvision/data/mixup.py

 def rand_bbox(img_shape, lam, margin=0.0, count=None):
    """ Standard CutMix bounding-box
-    Generates a random square bbox based on lambda value. This impl includes
+    generates a random square bbox based on lambda value. This implementation includes


这个开头需要大写，和上面那个不算同一行，Generates

收到，已修改

rentainhe · 2022-05-04T16:59:57Z

flowvision/scheduler/multistep_lr.py

 class MultiStepLRScheduler(Scheduler):
    """MultiStep LRScheduler
-    Decays the learning rate of each parameter group by decay_rate once the 
+    decays the learning rate of each parameter group by decay_rate once the 


这边儿同上~~需要大写开头的~~

收到，已修改

rentainhe · 2022-05-04T17:00:05Z

flowvision/scheduler/step_lr.py

 class StepLRScheduler(Scheduler):
    """ Step LRScheduler
-    Decays the learning rate of each parameter group by 
+    decays the learning rate of each parameter group by 


收到，已修改

rentainhe · 2022-05-04T17:00:48Z

flowvision/utils/vision_helpers.py

    format: Optional[str] = None,
 ) -> None:
-    """Save a given Tensor into an image file.
+    """Saves a given Tensor into an image file.


emmm，我其实感觉这些都不太需要第三人称的形式

您好，这个问题我想请教一下，如果按照英文祈使句的语法规则，句首动词应该用动词原型，但是我看FlowVision仓库里的文本，有很大一部分都用的第三人称，而且Torchvision里也有使用第三人称的情况，因此我为了文章前后统一，才把这些改为了第三人称。由于我不太懂编程，所以想请教一下编程当中对句首动词人称的选择是根据一般的语法规则呢？还是有独特的规定？

其实都OK吧，只要你前后统一就行了~，话说这个PR可以继续推进一下嘛，争取这两天合并进去

refine_flowvision

43ffd66

doombeaker reviewed Apr 29, 2022

View reviewed changes

Ldpe2G requested a review from oneflow-ci-bot April 29, 2022 07:11

JensenPL added 3 commits April 29, 2022 16:39

refine

ffa556d

refine

396cfc8

refine

d6d5631

rentainhe reviewed May 4, 2022

View reviewed changes

refine

d20584e

	Flowvision supports two ways to create a model:
	FlowVision supports two ways to create a model:

	generates a random square bbox based on lambda value. This impl includes
	generates a random square bbox based on lambda value. This implementation includes

Conversation

JensenPL commented Apr 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants