More tidyups vaguely related to fully-dated trees#129
Merged
Conversation
There's 2 sets of 2 nodes with the same name. When we dict(zip(names, remainder)), one of them is chosen arbitarily, and potentially flapping, causing DVC noise. Remove all 4 names to solve the inconsistencies, and add ERROR output if/when the situation arises again. Fixes #125
Work through a list of file arguments to version/copy into place, with lots of special cases for existing files. Ideally this would be responsible for the versioning and not the cutmapping, but that can come later.
Instead of relying on log messages, write out an import script. Move upload instructions to README.markdown & update to use this.
It's no longer used, so don't bother generating it.
Add to standard logging setup a handler to count error messages emitted. On exit, if any came out then treat the script as failed and exit with status 1, stopping the pipeline. This means we can easily do things like report problems for all missing/duplicate items in a tree without having to handle stop/restart behaviour.
lentinj
force-pushed
the
issue-120-more-prerequisites
branch
from
0324d9f to
5f2ee7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another bunch of things that came up whilst looking at the fully dated tree.
This doesn't apply the logging.error-means-script-fails-at-end change universally, that will come as we restructure things.
Fixes #125