Remove dates js / fake_migrate config option#1011
Merged
Merged
Conversation
Mine up fake_migrate to the config, so it's easier to set when required. Add some documentation for cloning databases, which requires it.
On closer inspection, seems the dates.js file isn't actually used. There is no code that accesses the .date property, all other references to tree_date are setup. The dates shown on the tree seem to be coming from node_details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dates.js file is only ever referenced by the node date property, which is never actually used.
When rendering dates in nodes, we actually use "lengthbr", populated from
node_details.node_cols["age"].Also, add an easier-to-get-to config option for when you need to use fake-migrate, and document doing so.