Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306
Manoj - Add inventory navigation icons, cross-page links, and BM Dashboard dropdown under Other Links#5306ManojPuttaswamy wants to merge 29 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
one-community
added
the
High Priority - Please Review First
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
- Verified navigation to BM Dashboard through Other Links and confirmed the BM Dashboard header remains persistent after navigation as expected.
- Verified the new "All Inventory Types" option is available under the BM Projects dropdown and navigates correctly.
- Verified all inventory categories (Materials, Consumables, Equipments, Reusables, Tools, and Unit of Measurement) can be expanded and collapsed successfully.
- Verified navigation from All Inventory Types to individual category pages and confirmed category data is displayed correctly.
- Verified Back to All Inventory Types functionality works as expected from category pages.
- Verified the updated BM Projects dropdown structure and inventory type icons are displayed correctly.
Issue Found
Dark Mode UI Inconsistency: When navigating back from category pages (e.g., Materials, Consumables) to All Inventory Types using the "All Inventory Types" button or icons, some table elements retain light-theme styling instead of adopting dark-mode colors. This results in reduced readability and an inconsistent user experience in Dark Mode. (Refer last screenshot.)
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Manoj,
I tested this locally following the steps provided and found 2 issues:
Unit of Measurement is missing from the BM Projects dropdown.
Dark mode - The BM Projects dropdown has a slight misalignment in dark mode.
PR.5306.mp4
amaresh2001
left a comment
amaresh2001
left a comment
There was a problem hiding this comment.
Tested locally on Manoj_BMDashboard.
Testing:
- "BM Dashboard" is correctly listed under the Other Links dropdown
- "All Inventory Types" appears in the BM Projects dropdown and routes correctly to /bmdashboard/inventorytypes
- Dropdown closes after selecting an option
- Categories (Materials, Consumables, Equipment, Reusables, Tools) are clickable navigation links with icons
- "← All Inventory Types" back link is present on each category page
Issues:
- Unit of Measurement is not a clickable link; all other categories on the Inventory Types page are clickable navigation links.
- Dark mode inconsistency on navigation back when in dark mode and navigating from a category page back to /bmdashboard/inventorytypes, the page body renders with a white/light background while the navbar remains dark. The page does not fully apply dark mode styling on return navigation.
Hi, Dark mode inconsistency has been fixed. Please re review it and Thankyou. |
Hi, the Issue 01 that you have mentioned, I believe Unit of Measurement is not supposed to be a clickable link. And, the second issue has been resolved. Please re review it. Thank you |
ManojPuttaswamy
requested review from
DeepighaJ,
HemanthNidamanuru and
amaresh2001
Hi, The first issue, I believe that the unit of measurement is not a category and hence there is no navigation to it. The second issue has been resolved. Please re review it. Thankyou |
Text me when the unit of measure link is fixed too, so I can request re-review |
Mahitha-pasupuleti
left a comment
Mahitha-pasupuleti
left a comment
There was a problem hiding this comment.
Hi Manoj,
I reviewed and tested this PR. The BM Dashboard header persists correctly across navigation, and the new "All Inventory Types" feature is functioning as expected. Navigation between inventory categories works properly, and the back to All Inventory Types functionality returns users to the main inventory page without issues.
I also verified the BM Projects dropdown structure, inventory type icons, and overall navigation flow. All functionality works correctly in both light mode and dark mode.
Everything is working according to the requirements. Approving this PR.
handikaharianto
left a comment
handikaharianto
left a comment
There was a problem hiding this comment.
Hi @ManojPuttaswamy , I just reviewed the PR and here are my findings:
Good
bmdashboard header persistence under other links
“All Inventory Types” under the BM projects dropdown
I can see that all icons are mapped consistently with their inventory types.
dark/light modes work well
The layout is consistent across both dark/light modes.
Doubts
Materials -> Log Material page leads to not found page
This log material url leads to a not found page.
Add Consumable page doesn't show up
When I clicked on Consumables -> Add Consumables, the url added /add but the page to add consumables doesn't show up.
Inconsistency between the All Inventory Types page and dropdown
In the page, I can see that there is Unit of Measurement but it's not in the dropdown.
BM Projects -> Issues page is not found.
I noticed that clicking on the Issues url redirected me to a not found page.
UX improvement for navigating through the inventory types page.
Here, it's good that I can easily navigate through other inventory type pages, however, it might be better to add a tooltip when the user is hovering their mouse on the icon so that they know which inventory type it is.
BM Projects dropdown disappears
I noticed that the BM Projects dropdown only appears after only selecting a project in the Building and Inventory Management Dashboard. Is this the expected behavior?
|
Hi @ManojPuttaswamy I reviewed the pr and following are my reviews: BM Dashboard NavigationVerified
Screenshot
Responsive DesignIssueOn mobile/smaller screen widths, text does not wrap properly and the page does not appear fully responsive. All Inventory Types NavigationVerified
Screenshot
Inventory CategoriesVerifiedAll inventory categories can be expanded/collapsed and are clickable:
Screenshot
Dark ModeVerifiedDark mode styling appears to work correctly on the Inventory Types page. BM Projects DropdownVerifiedBM Projects dropdown displays the expected links and navigation works correctly. Screenshot
Date FilterIssueThe date filter appears to have no visible effect on the displayed data. Please verify whether the filter is fully implemented or if functionality is missing. Screenshot
Calendar UXIssue
Screenshot
Log Material / Issue PagesIssueBoth pages return a Page Not Found error. Screenshot
Screenshot
Teams Page NavigationIssueThe BM Projects option is not visible under Other Links on the Teams page. It appears to be clipped or hidden. Screenshot
Teams Page Dark ModeIssueDark mode styling is inconsistent on the Create New Team page. Screenshot
UI ConsistencyIssueDifferent inventory pages use noticeably different table styles and layouts. The UI should be more consistent across:
Mobile ResponsivenessIssueInventory pages should be optimized for smaller devices and mobile screens. Screenshot
SummaryVerified
Request ChangesThe following issues should be addressed before approval:
|
AmaanSyed09
left a comment
AmaanSyed09
left a comment
There was a problem hiding this comment.
Testing Performed
-
Verified the BM Dashboard is accessible through the Other Links dropdown.
-
Verified All Inventory Types appears under the BM Projects dropdown menu.
-
Verified selecting All Inventory Types correctly routes to
/bmdashboard/inventorytypes. -
Verified the dropdown closes after selecting a menu option.
-
Verified all inventory category navigation links function correctly:
- Materials
- Consumables
- Equipment
- Reusables
- Tools
- Unit of Measurement
-
Verified each inventory category page loads successfully and displays the expected content.
-
Verified the ← All Inventory Types navigation link is present on all category pages.
-
Verified the ← All Inventory Types link correctly returns users to the Inventory Types page.
-
Verified navigation works correctly in both Light Mode and Dark Mode.
-
Verified Dark Mode styling remains consistent after navigating between inventory pages.
-
Reviewed the modified files and confirmed the implemented changes align with the scope of the PR.
Additional Observation
The Issues item under the BM Projects dropdown currently routes to a Page Not Found page during local testing. Since this functionality does not appear to be part of the requirements described in this PR, I am noting it as an observation rather than a blocking issue. It may be worth verifying separately whether the route is expected to be functional.
Result: Approve
All requested functionality described in the PR was successfully tested and is working as expected.
ManojPuttaswamy
force-pushed
the
Manoj_BMDashboard
branch
from
08e9260 to
2c10510
Compare
Dnagabahiru
left a comment
Dnagabahiru
left a comment
There was a problem hiding this comment.
Tested the PR locally after clearing cache and logging in as an admin user. Verified that the BM Dashboard header remains persistent, the new All Inventory Types option is available under BM Projects, and navigation to the Inventory Types page works as expected. Confirmed the updated dropdown structure, inventory icons, and navigation across all inventory categories (Materials, Consumables, Equipment, Reusables, Tools, and Unit of Measurement) function correctly.
Also verified that the ← All Inventory Types navigation link is present and returns users to the main Inventory Types page from each category. Tested all functionality in both Light Mode and Dark Mode, with consistent styling and expected behavior throughout. As an observation, the Issues option under BM Projects currently redirects to a Page Not Found page, which appears to be outside the scope of this PR.
Dnagabahiru
requested review from
Dnagabahiru
and removed request for
Dnagabahiru
Dnagabahiru
left a comment
Dnagabahiru
left a comment
There was a problem hiding this comment.
Tested the PR locally after clearing cache/site data and logging in as an admin user. Verified that the BM Dashboard header persistence, All Inventory Types entry, updated BM Projects dropdown structure, inventory category navigation, inventory icons, and Light/Dark Mode functionality are all working as expected.
During testing, I found two navigation issues within the BM Projects menu:
Issues redirects to a Page Not Found page.
Materials Log (logMaterial) also redirects to a Page Not Found page.
Since these options are exposed through the BM Projects navigation, users are able to access broken routes from the UI.
Result: Request Changes
Please resolve the broken navigation for Issues and Materials Log before approval.
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Manoj,
Retested this locally. Both issues have been rectified:
- Unit of Measurement is now present in the BM Projects dropdown
- BM Projects dropdown alignment in dark mode is fixed
Everything is working fine now.
ManojPuttaswamy
force-pushed
the
Manoj_BMDashboard
branch
from
5d90a45 to
a4c1644
Compare
handikaharianto
left a comment
handikaharianto
left a comment
There was a problem hiding this comment.
Hi, after your latest updates, here's my findings:
Fixed
Unit of Measurement has been added to the "BM Projects" dropdown✅
Previously, the Unit of Measurement didn't exist under the BM Projects dropdown. Now it has been added and it's working properly.
Requires some changes
Log material page is not found.❌
Add Consumable page is not found❌
The Add Consumable link under the BM Projects dropdown redirects to the Consumable List page.
Issues page is not found❌
The Issues page under the BM Projects results in a not found page.
|
kzou55
left a comment
kzou55
left a comment
There was a problem hiding this comment.
Hi Manoj,
I ran and tested this branch locally.
I can verify the following:
- bmdashboard header persists under other links
- "All Inventory Types" feature appears under the BM projects dropdown
- Both the navigation for each categories in "All Inventory Types" pages and the "back to all inventory types button" functions correctly.
- All the icons are added correctly for the inventory types
- The implemented functionality also works in Dark Mode
Testing in Light Mode
Recording.2026-06-19.165008.mp4
Testing in Dark Mode
Recording.2026-06-19.165249.mp4
Issues/Concerns:
-
Dark Mode has some contrast issues. The text is barely visible in all the pages besides "Unit of Measurement".
-
Not sure if this is the right PR to address this but the following pages are not found
-
Log Material Page missing:
bmdashboard/logMaterial -
Issue page from the dropdown in Other Links:
/bmdashboard/Issue
-
pixelpix13
left a comment
pixelpix13
left a comment
There was a problem hiding this comment.
Hi @ManojPuttaswamy I reviewed the pr and following are my reviews:
BM Dashboard Navigation
Verified
- BM Dashboard menu appears correctly under Other Links.
- Header remains visible after navigation.
- Refreshing the page works correctly.
- Navigation away from and back to the page works correctly.
- Browser back/forward navigation works as expected.
- Dark mode and light mode both function properly.
Screenshot
Responsive Design
Issue
On mobile/smaller screen widths, text does not wrap properly and the page does not appear fully responsive.
All Inventory Types Navigation
Verified
- "All Inventory Types" appears in the BM Projects dropdown.
- Clicking the option routes correctly.
- Dropdown closes after selection.
Screenshot
Inventory Categories
Verified
All inventory categories can be expanded/collapsed and are clickable:
- Materials
- Consumables
- Equipment
- Reusables
- Tools
- Unit of Measurement
Screenshot
Dark Mode
Verified
Dark mode styling appears to work correctly on the Inventory Types page.
BM Projects Dropdown
Verified
BM Projects dropdown displays the expected links and navigation works correctly.
Screenshot
Date Filter
Issue
The date filter appears to have no visible effect on the displayed data. Please verify whether the filter is fully implemented or if functionality is missing.
Screenshot
Calendar UX
Issue
- Calendar navigation arrows are difficult to see.
- Calendar UX could be improved by preventing invalid date selections.
- Future dates should be disabled where appropriate.
- Invalid date ranges should be prevented.
Screenshot
Log Material / Issue Pages
Issue
Both pages return a Page Not Found error.
Screenshot
Screenshot
Teams Page Navigation
Issue
The BM Projects option is not visible under Other Links on the Teams page. It appears to be clipped or hidden.
Screenshot
Teams Page Dark Mode
Issue
Dark mode styling is inconsistent on the Create New Team page.
Screenshot
UI Consistency
Issue
Different inventory pages use noticeably different table styles and layouts.
The UI should be more consistent across:
- Materials
- Consumables
- Equipment
- Reusables
- Tools
- Unit of Measurement
Mobile Responsiveness
Issue
Inventory pages should be optimized for smaller devices and mobile screens.
Screenshot
Summary
Verified
- BM Dashboard navigation
- Inventory navigation links
- Expand/collapse functionality
- Inventory category routing
- Dark mode on inventory pages
- BM Project dropdown navigation
Request Changes
The following issues should be addressed before approval:
- Missing pages (Log Material / Issue)
- Teams page navigation visibility issue
- Date filter functionality concerns
- Calendar UX improvements
- Teams page dark mode inconsistency
- Mobile responsiveness concerns
- UI consistency improvements across inventory pages
12 participants
Description
Related PRS (if any):
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
REC-20260530200247.mp4
Notes: