Veda permission question sets#5103
Open
Charitha2009 wants to merge 39 commits into
Open
Conversation
…ing job form builder
…ob_Posting_Page/Function_Create_permission_to_create_different_question_sets
…/frontend/Application/Job_Posting_Page/Function_Create_permission_to_create_different_question_sets
Resolve conflicts: keep Enhanced job form route plus analytics imports; Permissions.json adds Job Form Management; Collaboration JobFormbuilder uses permissions and API requestor; list forms from GET /jobforms/all { forms }; EnhancedJobFormBuilder same forms parsing.
Made-with: Cursor
…s allowed Made-with: Cursor
…tion list Made-with: Cursor
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Co-authored-by: Cursor <cursoragent@cursor.com>
…rmBuilder Associate position title label with input; format className and Remove button for lint/CI. Co-authored-by: Cursor <cursoragent@cursor.com>
nathanah
requested changes
May 10, 2026
Contributor
There was a problem hiding this comment.
- Use the existing
hasPermission()so functionality is consistent with other permissions. - Run the check once when setting the variable instead of every time the variable is used.
I tried to find all the changes needed to make it easier for you, but I may have missed some.
Also, it should have a backend PR?
one-community
added
the
High Priority - Please Review First
Auto-fix and reorder share button selectors so the branch can pass CI style checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract helpers and subcomponents to reduce cognitive complexity, log caught errors, flip negated ternaries, and use stable keys for general links. Co-authored-by: Cursor <cursoragent@cursor.com>
Use darker green button backgrounds and darker placeholder text to meet WCAG contrast requirements. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove unused Alert import, add PropTypes, and use stable keys for question and option lists. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove unused Form import, add PropTypes, log caught errors, and use stable keys for sample questions. Co-authored-by: Cursor <cursoragent@cursor.com>
Move the card subcomponent to module scope with PropTypes and pass handlers as props. Co-authored-by: Cursor <cursoragent@cursor.com>
Destructure questionSet fields and define the shape inline so ESLint validates description, questions, and usageCount. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract SampleQuestionListItem with PropTypes, rename map/handler params, and require questions array on questionSet. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract GeneralLinkRow and pass scalar props instead of nested formData so react/prop-types no longer flags formData.jobLinks or settings access. Co-authored-by: Cursor <cursoragent@cursor.com>
DeepighaJ
requested changes
Jun 2, 2026
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
- Checked out to current branch and tested PR locally
- I'm able to add new custom field question to the template.
- The email is required field but its not available in preview and doesn't show text box in the template.
- The edit pop up has visibility issue in dark mode.
- Clone option is not working.
- For Question 14/15( longer text questions), the action button labels (Edit, Clone, Move Up, Move Down, Delete) appear compressed/shrunk compared to other questions.
Fix email question rendering, clone wiring, dark mode, HGN color theme, preview profile fields, and Save Form error handling with API sync. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Correct QuestionSetManager CSS module import, tighten FORM CREATION heading spacing, and improve template controls with labeled rows and consistent button styling. Co-authored-by: Cursor <cursoragent@cursor.com>
Use stable IDs for edit-modal option rows instead of array index keys, and improve disabled Clear Template button text contrast in light and dark mode. Co-authored-by: Cursor <cursoragent@cursor.com>
Use crypto.randomUUID when available, otherwise a deterministic counter for stable React list keys without triggering pseudorandom security lint. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Co-authored-by: Cursor <cursoragent@cursor.com>
…sues Send requestor on question/template API calls, normalize isRequired across load/save/clone, and improve dark mode styling in the edit modal and page. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace gray panel fills with white surfaces and subtle borders for a cleaner form creation layout. Co-authored-by: Cursor <cursoragent@cursor.com>
Add isRequired prop validation, explicit checkbox spacing, and use structuredClone for question cloning. Co-authored-by: Cursor <cursoragent@cursor.com>
nathanah
requested changes
Jun 15, 2026
nathanah
left a comment
nathanah
left a comment
Contributor
There was a problem hiding this comment.
Still need to use hasPermission instead of hasPermissionSimple and memoize permission check results.
There's a guide on how to use and set up permissions in the permissions design doc.
Replace hasPermissionSimple with dispatch(hasPermission) so role defaults are respected, and memoize job form permission results per review. Co-authored-by: Cursor <cursoragent@cursor.com>
nathanah
approved these changes
Jun 22, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This frontend PR is related to the #2237 backend PR.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes: