Veda job application form page#4958
Open
Charitha2009 wants to merge 31 commits into
Open
Conversation
added 14 commits
December 5, 2025 22:06
…-disable comments
Fixes: 1. Fixed 'Apply Now' button to show application form instead of redirecting to external URL 2. Fixed job listings to load automatically on page load (removed requirement for search/category filter) 3. Fixed HTML tags displaying in job descriptions - added HTML stripping function 4. Fixed job card layout to match design: - Reduced icon size from 150px to 60px for compact display - Adjusted card padding and sizing for better proportions - Fixed font sizes for title and description - Made Apply Now button full-width at bottom 5. Fixed search section layout - vertical stacking in green navbar 6. Fixed job description on application page - strips HTML tags for clean display 7. Improved error handling in JobApplicationPage for better reliability 8. Matched styling with provided branch implementation while keeping improvements
…s, update styling to match design - Add isAdmin prop and requirements checking logic - Create RequirementsSection component with two-column layout - Update button styling to green (#69B369) scoped to component only - Update header styling (light gray background, green title text) - Add admin view detection in JobApplicationPage - Add padding below form for better spacing
…m requirements section
…h proper images, referral link support, and user requirements section
…ing HEAD version with category-based view
…actual API call order and parameters
- Collaboration.jsx: keep branch behavior (fetchJobAds, selectedCategory, summaries pagination, history.push to job-application, category images) - Collaboration.module.css: keep branch styles (header, collabContainer, jobLandingDark, summariesList, pagination) - JobApplicationForm.module.css: keep admin/user requirements section and dark mode - Collaboration.test.jsx: keep fetch expectation with stringContaining and method GET - authInit.js: use console.error for invalid token (development) Made-with: Cursor
Made-with: Cursor
- JobApplicationForm: remove vulnerable regex in stripHtml fallback (use whitespace-only cleanup) - Collaboration.module.css: fix .jobAd h3 conflicting margin/margin-top (use single margin declaration) Made-with: Cursor
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
added 3 commits
March 7, 2026 17:04
Collaboration.jsx: - Remove unused isAdmin; use globalThis instead of window - Move getColumnsFromMQ to module scope; optional chain in getUniqueCategories JobApplicationForm.jsx: - Handle exception in isAdmin selector (log error) - Remove unused handleShowDescription - Use replaceAll instead of replace in stripHtml - Reduce cognitive complexity (extract applyQuestionnairePreFill) - Add PropTypes for RequirementsSection and UserRequirementsSection SuggestedJobsList.jsx: use replaceAll for whitespace cleanup Collaboration.module.css: improve contrast (disabled button, dark hover) Made-with: Cursor
…new code - Single RequirementsSection with variant prop (admin/user) instead of two components - Shared REQUIREMENT_ITEMS config and CheckIcon; build list from requirements[id] - Lowers duplicated lines for SonarCloud Quality Gate (target ≤3%) Made-with: Cursor
Made-with: Cursor
|
Vishnu10-hub
approved these changes
Mar 8, 2026
Vishnu10-hub
left a comment
Vishnu10-hub
left a comment
There was a problem hiding this comment.
Checked out the branch and ran the application locally.
Navigated to /collaboration and clicked Apply on a listed job.
Verified the Job Application Form loads correctly with the job title, description, and requirements.
Confirmed checkbox states reflect user data and styling is consistent with other Applications pages.
Verified the page renders correctly in both light and dark modes.
Anusha-Gali
suggested changes
Mar 11, 2026
There was a problem hiding this comment.
Hi Veda,
I have reviewed your PR locally and i see the duplication of the questions as well as few questions are not similar to the figma requirement : https://www.figma.com/design/Amg28wlU9ENb7CWHuKF88p/Applicants-Analytics-Dashboard?node-id=77-1200&t=7eqcYfwpfTIDjwpS-0 and also there is no mandatory questions to be answered and other form pre-requisites being fulfilled (do let me know if this was a part of the PR and i will provide individuals misses)
Also on a side note i do not see the Apply button you mentioned in the description.
rohanrastogi311
suggested changes
Mar 15, 2026
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Charitha,
Well done with this implementation. The check boxes aren't functional though.
HemanthNidamanuru
requested changes
Mar 16, 2026
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Charitha,
Good work on the implementation! Just wanted to let you know the checkboxes are not functioning and there are some repeated questions. Could you please take a look?
one-community
added
the
High Priority - Please Review First
Integrate collaboration job board with upstream form UX: dynamic questions, referral/job pre-fill, requirements checks, and URL endpoints for job lookup. Co-authored-by: Cursor <cursoragent@cursor.com>
Make Requirements Status actionable for owner/admin with overrides, harden job-title form matching and required-field detection, tighten layout (full-width fields, card alignment), hide global back-to-top, and paint html/body/#root on this route so scrolling no longer shows a white band under the gray page. Stylelint: visually-hidden clip-path, requirement checkbox specificity order, and role group aria fixes for eslint. Co-authored-by: Cursor <cursoragent@cursor.com>
…plicationForm Reduce cognitive complexity, improve accessibility with native buttons, fix WCAG button contrast, and clean up lint smells in form helpers and requirement evaluation. Co-authored-by: Cursor <cursoragent@cursor.com>
Use fieldsets for option groups, fix label spacing and requirement toggles, improve button and dark-mode tag contrast, and prefer globalThis in Collaboration tests. Co-authored-by: Cursor <cursoragent@cursor.com>
DeepighaJ
requested changes
May 28, 2026
There was a problem hiding this comment.
- Checked out to current branch and tested PR locally. Below are the findings.
- Page has excessive empty scroll space below the form content. Layout/container height does not properly fit the content, resulting in unnecessary vertical scrolling.
- There is no upload button to attach document for resume and second upload instead textbox is available.
- There is a upload button on top and it doesn't show the upload status of document uploaded or not.
- Application gets successfully and success toast appears
Keep branch Collaboration job board and application navigation; development rewrote the same component with a different modal-based flow. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire the form to the real submit API, add visible file upload controls with status, and remove excess page scroll below the content. Co-authored-by: Cursor <cursoragent@cursor.com>
Job ads requests now pass an abort signal; use objectContaining so tests match the updated fetch options. Co-authored-by: Cursor <cursoragent@cursor.com>
…zation Extract helpers to resolve Sonar cognitive complexity and nested ternary warnings. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Hide resume/CV questions 19–20 from the dynamic list and use a single profile resume field, honoring required flags from the form definition. Co-authored-by: Cursor <cursoragent@cursor.com>
DeepighaJ
requested changes
Jun 12, 2026
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
- Tested the PR locally, Upload button works fine as expected.
- The questions Name, Email, Location&timezone, Phonenumber, Company position , Primary website/social page is duplicated. Highlighted it in screenshot below.
- The error toast displays "Must be a number" for all fields.
- The job description link works as expected.
Co-authored-by: Cursor <cursoragent@cursor.com>
Simplify question-number regex and wrap file upload label text to fix ambiguous JSX spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
|
DeepighaJ
requested changes
Jun 17, 2026
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
Tested the PR locally and found the issues remain the same and not resolved.
Keep feature-branch Collaboration.jsx with job application navigation while integrating latest development changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Restrict numeric validation to hours-per-week questions so text answers no longer trigger false "must be a number" errors on submit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This is a redo of #4583
Checkout to #2255 backend PR.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes: