Shravya-Bugfix-ActivitiesPage-module.css#4756
Conversation
It was remapped to communityportal/Activities/ActivitiesPage from communityportal/Activities
styles.css => Activitiesstyles.module.css kabab case to camel case removal of duplicates in css
import module.css file instead of just styles.css fix inside tags the convention for styling remove style attribute inside tags
1. light colors 2. jsx structures
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…/ActivitiesPage_3370
ShravyaKudlu
added
the
High Priority - Please Review First
|
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Shrayva,
Well done with this implementation, calendar is not dark mode.
|
|
@rohanrastogi311, implemented the changes please re-review |
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
Checked out to current branch and tried running it and got npm error on running npm install . Tried to change node version still getting error.
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi,
I tested this locally following the steps provided. Filter by date is working fine.
However, I noticed 1 issue: registration is allowed even with past dates. Does this fall under the scope of this PR?
|
@DeepighaJ, can you please check again |
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Shravya,
I retested this PR locally. The previously reported issue with registration being allowed for past dates has been resolved. However, I noticed the position of the Status and Resources fields could be better aligned.
|
4 participants
Description
Fixes bugs, in #3370
951 Phase 3: Fix Bug Preventing Access to PR 3370 on Dev Environment after Merg
Related PRS (if any):
This frontend PR is related to the development backend.
Main changes explained:
Removed .css, and added module.css, and modified the styles as per guidelines
How to test:
npm installand...to run this PR locallyhttp://localhost:5173/communityportal/ActivitiesPageScreenshots or videos of changes:
Note:
This is based on mock data
The functionality based on #3370.
Expect, approve button in latest registration not to do anything,
calendar was not a functionality added previously, register, just displays the notification, and the dates added, you can only filter by date, and create new doesnt do anything as its as per mock data