Sai Sandeep taking over for Xinyi - fix: project and tool filters#4537
Sai Sandeep taking over for Xinyi - fix: project and tool filters#4537RitzzzZ2021 wants to merge 17 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thanks for testing out and letting me know the changes that needed to be addressed hemanth, i made changes as requested. Please re test once you have a chance do it |
kzou55
left a comment
There was a problem hiding this comment.
Hi Sai Sandeep,
I ran the current branch locally.
I can verify the following works:
- Both the "Project" and "Tool" filters are searchable using type-ahead
- The multi-select option allows users to view data for multiple projects simultaneously
- The "x" button clears the filters
- Functionality works in Dark Mode
Testing in Light Mode
Recording.2026-06-19.181747.mp4
Testing in Dark Mode
Recording.2026-06-19.181918.mp4
Issues:
- Dark Mode layout is still a bit inconsistent compared to Light Mode.
See in the image below how there's a different color above the tool's title. Meanwhile in Light Mode, it's a clear white.
- Might be out of scope for this PR, but is there a reason why the Project filter is correctly associated with the Project column. But for "Tool", the respective column is referred to as "Name".
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sandeep,
Retested this PR locally. The area covered has improved, but found the following remaining issues:
- In light mode, when there are fewer rows in the table, the remaining empty space below shows black instead of white
- In dark mode, the remaining empty space below the table also shows black instead of the page's dark background color
- In dark mode, there is also a different background color showing above the Tools title
|
Hi Hemanth addressed all issues. Do re test once you have chance. Should be all good |





























Description
Related PRS (if any):
None.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before:
After:
Video of changes
Screen.Recording.2026-06-15.013939.mp4