Skip to content

Sai Sandeep taking over for Xinyi - fix: project and tool filters#4537

Open
RitzzzZ2021 wants to merge 17 commits into
developmentfrom
xinyi_fix_tool_filter
Open

Sai Sandeep taking over for Xinyi - fix: project and tool filters#4537
RitzzzZ2021 wants to merge 17 commits into
developmentfrom
xinyi_fix_tool_filter

Conversation

@RitzzzZ2021

@RitzzzZ2021 RitzzzZ2021 commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

None.

Main changes explained:

  • Update file ItemListView.module.css to refine styling.
  • Update file SelectFrom.jsx and SelectItem.jsx to add multi-select and reset functionality to filters.
  • Update file ToolItemListView.jsx to support multi-select functionality.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/bmdashboard/tools
  6. verify both “Project” and “Tool” filters are searchable using type-ahead
  7. verify multi-select option to view data for multiple projects simultaneously
  8. verify filters can be reset using "x" button
  9. verify this new feature works in dark mode

Screenshots or videos of changes:

Before:

image

After:

Screenshot 2026-06-09 043331 Screenshot 2026-06-09 043343

Video of changes

Screen.Recording.2026-06-15.013939.mp4

@netlify

netlify Bot commented Dec 10, 2025

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 8b63d0e
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6938ba59e2e0220008532052
😎 Deploy Preview https://deploy-preview-4537--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Xinyi,

I have tried to review your PR locally and though the functionality does work as intended, the dropdown text nor the "x" button are visible in dark mode
Screenshot 2025-12-11 at 11 39 34 PM
Screenshot 2025-12-11 at 11 39 36 PM
Screenshot 2025-12-11 at 11 38 32 PM
Screenshot 2025-12-11 at 11 38 38 PM
Screenshot 2025-12-11 at 11 38 54 PM

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context labels Feb 27, 2026
@one-community one-community changed the title Xinyi - fix: project and tool filters Sai Sandeep taking over for Xinyi - fix: project and tool filters Jun 8, 2026
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 18db78c
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a38e366a7076400085b5d7c
😎 Deploy Preview https://deploy-preview-4537--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context labels Jun 16, 2026

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sandeep,

Tested this PR locally. Everything is working fine, but in light mode the page is not covering the entire space, leaving dark background visible on the sides. Screenshot attached.

Image Image Image Image Image Image

@saisandeepkoritala

Copy link
Copy Markdown
Contributor

Hi Sandeep,

Tested this PR locally. Everything is working fine, but in light mode the page is not covering the entire space, leaving dark background visible on the sides. Screenshot attached.

Image Image Image Image Image Image

Thanks for testing out and letting me know the changes that needed to be addressed hemanth, i made changes as requested. Please re test once you have a chance do it

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sandeep,

Retested this PR locally. The area covered has improved, but the issue is still there: in light mode the page is not covering the entire space, leaving dark background visible on the sides. Screenshot attached.

Image

@saisandeepkoritala

Copy link
Copy Markdown
Contributor

Hi Sandeep,

Retested this PR locally. The area covered has improved, but the issue is still there: in light mode the page is not covering the entire space, leaving dark background visible on the sides. Screenshot attached.

Image

Thanks for testing hemanth and letting me know the changes that needed to be addressed, i made changes as requested. Please re test once you have a chance do it. Thank you

@kzou55 kzou55 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sai Sandeep,

I ran the current branch locally.

I can verify the following works:

  • Both the "Project" and "Tool" filters are searchable using type-ahead
  • The multi-select option allows users to view data for multiple projects simultaneously
  • The "x" button clears the filters
  • Functionality works in Dark Mode

Testing in Light Mode

Recording.2026-06-19.181747.mp4

Testing in Dark Mode

Recording.2026-06-19.181918.mp4

Issues:

  • Dark Mode layout is still a bit inconsistent compared to Light Mode.
    See in the image below how there's a different color above the tool's title. Meanwhile in Light Mode, it's a clear white.
Image Image
  • Might be out of scope for this PR, but is there a reason why the Project filter is correctly associated with the Project column. But for "Tool", the respective column is referred to as "Name".

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sandeep,

Retested this PR locally. The area covered has improved, but found the following remaining issues:

  • In light mode, when there are fewer rows in the table, the remaining empty space below shows black instead of white
  • In dark mode, the remaining empty space below the table also shows black instead of the page's dark background color
  • In dark mode, there is also a different background color showing above the Tools title
Image Image

DeepighaJ
DeepighaJ previously approved these changes Jun 20, 2026

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested the PR locally.
  • The filters are working as expected with muti-select options.
  • Filters can be reset using "x" button
  • The feature works fine in dark mode.
  • Update works fine as well
Image Image Image Image Image

@sonarqubecloud

Copy link
Copy Markdown

@saisandeepkoritala

Copy link
Copy Markdown
Contributor

Hi Sandeep,

Retested this PR locally. The area covered has improved, but found the following remaining issues:

  • In light mode, when there are fewer rows in the table, the remaining empty space below shows black instead of white
  • In dark mode, the remaining empty space below the table also shows black instead of the page's dark background color
  • In dark mode, there is also a different background color showing above the Tools title

Image Image

Hi Hemanth addressed all issues. Do re test once you have chance. Should be all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants