Saurabh D taking over for Vamsidhar dark mode materials update form#4511
Saurabh D taking over for Vamsidhar dark mode materials update form#4511vamsidharpanithi wants to merge 12 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Prem203
left a comment
Prem203
left a comment
There was a problem hiding this comment.
Reviewed the PR with an admin account and the tested all the scenarios in dark mode as mentioned. Everything works as expected.
--
--
--
Single material update:
Bulk material update:
http://localhost:5173/bmdashboard/materials/update
|
vamsidharpanithi
added
the
High Priority - Please Review First
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Vamsidhar,
I have reviewed your PR locally and have the below UI issues:
- negative values are allowed in unit price and total quantity which later are asked to be changed but shouldn't it not be allowed like it does in other pages
- the calendar is in light mode in dark mode page
- the country code dropdown options text is not visible, nor can we see the option selected
- negative values are allowed in the shipping fee and taxes which is not making sense, nor is it later asked to be edited
- upload material picture box is very huge, which i assumed is to preview the picture but the picture appears below the box and is not reduced to the frame size
- the submit button is not in blue color like it does in other pages
- time is not visible in Inventory types page
shashank-madan
left a comment
shashank-madan
left a comment
There was a problem hiding this comment.
Dark mode styles are not applied to all components.
Add.Material.-.Google.Chrome.2026-01-31.13-42-09.mp4
ShreyaMP1999
changed the title
saurabhdipte
changed the title
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Saurabh,
I tested the PR locally. After clicking on "Purchase Material" and completing a successful purchase request, the material list page is not getting displayed. Please look into this.
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
- Checkout to current branch and ran PR Locally.
- Add material in /bmdashboard/materials/add works as expected.
- The add material option in All Inventory Types allows Unit field to add any value even number words the field doesn't have validation.
- After submitting Purchase request, clicking on Go to Material List throws Error page. i.e, Navigating to http://localhost:5173/bmdashboard/materials also error.
- Update works as expected.
…nit dropdown validation on inventory types add row
saurabhdipte
force-pushed
the
vamsidhar-dark-mode-materials-update-form
branch
from
de50728 to
7a22d03
Compare
|
9 participants
Description
This PR fixes dark mode styling issues across multiple Materials Management pages in the BM Dashboard. The main issue was that text in table bodies, input fields, dropdowns, and other UI elements was not visible or had poor contrast in dark mode, making the interface unusable.
Related Issues:
Related PRS (if any):
Previous PR: 3158
Main changes explained:
Added dark mode styling to make all text, tables, inputs, dropdowns, and modals visible and readable across the Materials Update Form, Materials Inventory List, Purchase Record modal, Inventory Types List, and Add Material pages by setting dark backgrounds with white text and fixing the base color rules that were overriding dark mode styles.
How to test:
How to test:
check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
log as admin user
Follow the screenshot walkthrough below to test the add material, purchase material and update material feature
Testing Screenshot Walkthrough
Test newly added material is able to appear in material inventory list:
http://localhost:5173/bmdashboard/materials/add
http://localhost:5173/bmdashboard/inventorytypes
Test purchased material is able to appear in purchase material list:
http://localhost:5173/bmdashboard/materials/purchase
Test update materials(update a single material and update a bulk of material):
(Single material update)
(bulk material update)
http://localhost:5173/bmdashboard/materials/update