Add support to timeboost auctioneer for BidFloorAgent#4456
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add “BidFloorAgent” support to the timeboost auctioneer so a designated agent can be treated specially during auction resolution, along with some test refactoring and coverage additions.
Changes:
- Add
BidFloorAgentAddresstoAuctioneerServerConfigand introduce skip-resolution logic when the agent “wins”. - Refactor tests to reuse shared setup helpers for bid validators / auctioneer server setup.
- Add a new
TestBidFloorAgentand a changelog fragment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
timeboost/auctioneer.go |
Adds BidFloorAgent config + resolution logic intended to skip auction resolution when the agent is the winner. |
timeboost/auctioneer_test.go |
Refactors bid-validator setup and adds a new BidFloorAgent-focused integration test. |
timeboost/auctioneer_bid_consumption_test.go |
Deduplicates auctioneer server setup via a helper and threads through BidFloorAgent config. |
changelog/jcolvin-bidfloorvalidator.md |
Adds a changelog entry for the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
joshuacolvin0
force-pushed
the
bidflooragent
branch
from
16c3b60 to
7e5bcb9
Compare
Contributor
❌ 11 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4456 +/- ##
==========================================
- Coverage 32.90% 32.11% -0.79%
==========================================
Files 493 493
Lines 58295 58342 +47
==========================================
- Hits 19182 18739 -443
- Misses 35782 36253 +471
- Partials 3331 3350 +19 |
joshuacolvin0
force-pushed
the
bidflooragent
branch
3 times, most recently
from
f99f7b3 to
57a53b0
Compare
joshuacolvin0
force-pushed
the
bidflooragent
branch
from
57a53b0 to
5c65d0e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
rauljordan
approved these changes
Mar 5, 2026
Contributor
rauljordan
left a comment
rauljordan
left a comment
There was a problem hiding this comment.
Very clean PR with tests! Good stuff
eljobe
approved these changes
Mar 6, 2026
joshuacolvin0
added a commit
that referenced
this pull request
Mar 16, 2026
Adds parameter `--auctioneer-server.bid-floor-agent-address` If this address wins timeboost bid, that auction round is skipped
joshuacolvin0
added a commit
that referenced
this pull request
Mar 20, 2026
Port - Add support to timeboost auctioneer for BidFloorAgent (#4456)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes NIT-4599